From: Jay Vosburgh <fubar@us.ibm.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
martin@gear6.com
Subject: Re: [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance error
Date: Fri, 13 Nov 2009 15:47:33 -0800 [thread overview]
Message-ID: <6802.1258156053@death.nxdomain.ibm.com> (raw)
In-Reply-To: <20091113153058.4b739ea3@nehalam>
Stephen Hemminger <shemminger@vyatta.com> wrote:
>On Fri, 13 Nov 2009 15:13:01 -0800
>Jay Vosburgh <fubar@us.ibm.com> wrote:
>
>> + // check if all parameters are alike
>> + if (((ntohs(lacpdu->partner_port) == port->actor_port_number) &&
>> + (ntohs(lacpdu->partner_port_priority) == port->actor_port_priority) &&
>> + !MAC_ADDRESS_COMPARE(&(lacpdu->partner_system), &(port->actor_system)) &&
>> + (ntohs(lacpdu->partner_system_priority) == port->actor_system_priority) &&
>> + (ntohs(lacpdu->partner_key) == port->actor_oper_port_key) &&
>> + ((lacpdu->partner_state & AD_STATE_AGGREGATION) == (port->actor_oper_port_state & AD_STATE_AGGREGATION))) ||
>> + // or this is individual link(aggregation == FALSE)
>
>I know the code here doesn't follow kernel style, but please don't
>add more C99 comments or overly long lines.
I didn't, really; I moved the function up in the file rather
than adding a forward declaration.
-J
---
-Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com
next prev parent reply other threads:[~2009-11-13 23:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 23:13 [PATCH net-next-2.6] bonding: fix 802.3ad standards compliance error Jay Vosburgh
2009-11-13 23:30 ` Stephen Hemminger
2009-11-13 23:47 ` Jay Vosburgh [this message]
2009-11-16 6:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6802.1258156053@death.nxdomain.ibm.com \
--to=fubar@us.ibm.com \
--cc=davem@davemloft.net \
--cc=martin@gear6.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).