From: Paolo Abeni <pabeni@redhat.com>
To: Paul Fertser <fercerpav@gmail.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Liang He <windhl@126.com>, Geoff Levand <geoff@infradead.org>,
Leon Romanovsky <leon@kernel.org>,
Tao Ren <rentao.bupt@gmail.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: ftgmac100: support getting MAC address from NVMEM
Date: Tue, 18 Jul 2023 09:15:11 +0200 [thread overview]
Message-ID: <6818bc7ffe07c21d415265c00b00cf32c6d2ac6f.camel@redhat.com> (raw)
In-Reply-To: <ZLDas0gsLNkzuUWR@home.paul.comp>
On Fri, 2023-07-14 at 08:18 +0300, Paul Fertser wrote:
> Hello Pavan,
>
> On Fri, Jul 14, 2023 at 10:14:02AM +0530, Pavan Chebbi wrote:
> > On Thu, Jul 13, 2023 at 3:28 PM Paul Fertser <fercerpav@gmail.com> wrote:
> > > Make use of of_get_ethdev_address() to support reading MAC address not
> > > only from the usual DT nodes but also from an NVMEM provider (e.g. using
> > > a dedicated area in an FRU EEPROM).
> >
> > Looks like earlier ftgmac100_probe() would move on with self generated
> > (random) MAC addr if getting it from the device failed.
> > Now you will fail the probe in a failure case. Is that OK?
>
> I think the previous behaviour is preserved with this patch in all the
> cases other than of_get_ethdev_address returning -EPROBE_DEFER. Can
> you please explain what failure case you have in mind and how the
> probe is going to be failed in that case?
FTR, I agree with the above: it looks like the old behavior is
preserved. The patch LGTM, thanks!
Paolo
next prev parent reply other threads:[~2023-07-18 7:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 9:57 [PATCH] net: ftgmac100: support getting MAC address from NVMEM Paul Fertser
2023-07-14 4:44 ` Pavan Chebbi
2023-07-14 5:18 ` Paul Fertser
2023-07-18 7:15 ` Paolo Abeni [this message]
2023-07-18 7:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6818bc7ffe07c21d415265c00b00cf32c6d2ac6f.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fercerpav@gmail.com \
--cc=geoff@infradead.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pavan.chebbi@broadcom.com \
--cc=rentao.bupt@gmail.com \
--cc=windhl@126.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).