From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A595D253D4 for ; Tue, 18 Jul 2023 07:15:25 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F99910B for ; Tue, 18 Jul 2023 00:15:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689664518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LO/OU3eOEKbiSK+Rpa6237MBQHj5ytyRv/Karly+Uw4=; b=A5ZdXFyoSxGrEJSW68BKFT3EcXOX5u6qf4sZ86vt1ZDDpuAktf7LO+aA1ZdvsISDwZvQdT SVDkqbtj4Ov3TQKE9uqHEFXmyRL+qReG5/QYnKB3a8WV1945H116Y3x0rLZtBJs/NVXBcR V5gsdTxyBlT5ABSunncuXkWNNVihpWk= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-vQR-FW3oNZ2yuNjaK8o65Q-1; Tue, 18 Jul 2023 03:15:17 -0400 X-MC-Unique: vQR-FW3oNZ2yuNjaK8o65Q-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-639d9eaf37aso13439166d6.0 for ; Tue, 18 Jul 2023 00:15:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689664516; x=1692256516; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LO/OU3eOEKbiSK+Rpa6237MBQHj5ytyRv/Karly+Uw4=; b=FbyZlY5jW6D6Z+KH7Amk1jfcvhMJtPV8n7h5u6SuBvSqC+qM3UiaZQGJfwrohiWlrJ dX7NMUNINVOne3Ohx4n9EB/+uAaxhkkKDGoE1vVUFYpE1qaT9GlYed1zZ9nzLPmQ7+1M N1iV/rQu1EO7h+/NEhOX5Tu2QSHGb9GR4jD5tSYPn0oXi7v/t7rc+v6PFrQ8VJ273kHn g63boSLyqe73Ow+7/yMG/rJVfhsAsLEB5rfi9Mcyc1Bcied0VcQSNIEHsP7fFWzkVffH SrZ/9duRcH3dsiWC3aQiVlfEJ5Far3pG4XJa4ut0Ne09I3YIT+tejEddXeXZZWLJQA57 r5Ow== X-Gm-Message-State: ABy/qLaoBqscX4C5LVIX0+SnM3dZ4GutVmzGNmgDlqT3bgT+u4NKZvL3 QMiah3W/UAaiP2M3c/5bWEBAnniIi16g10wBGobp94HqXFlu4tRIK1QH97mv7yUOCBY3DLxvN2+ NihBBhXOTFi4+jtPq X-Received: by 2002:a05:622a:145:b0:403:b11f:29f0 with SMTP id v5-20020a05622a014500b00403b11f29f0mr12838198qtw.0.1689664516501; Tue, 18 Jul 2023 00:15:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFCnBH5LbDKP5eqb3how4HWFYkMEEbEjoni1XoZY9ApODHPDOx/exsxIFeKjFPBf7UcYJHAUw== X-Received: by 2002:a05:622a:145:b0:403:b11f:29f0 with SMTP id v5-20020a05622a014500b00403b11f29f0mr12838190qtw.0.1689664516267; Tue, 18 Jul 2023 00:15:16 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-226-170.dyn.eolo.it. [146.241.226.170]) by smtp.gmail.com with ESMTPSA id bt6-20020ac86906000000b003f364778b2bsm482217qtb.4.2023.07.18.00.15.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 00:15:15 -0700 (PDT) Message-ID: <6818bc7ffe07c21d415265c00b00cf32c6d2ac6f.camel@redhat.com> Subject: Re: [PATCH] net: ftgmac100: support getting MAC address from NVMEM From: Paolo Abeni To: Paul Fertser , Pavan Chebbi Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Andrew Lunn , Liang He , Geoff Levand , Leon Romanovsky , Tao Ren , Wolfram Sang , openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org Date: Tue, 18 Jul 2023 09:15:11 +0200 In-Reply-To: References: <20230713095743.30517-1-fercerpav@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On Fri, 2023-07-14 at 08:18 +0300, Paul Fertser wrote: > Hello Pavan, >=20 > On Fri, Jul 14, 2023 at 10:14:02AM +0530, Pavan Chebbi wrote: > > On Thu, Jul 13, 2023 at 3:28=E2=80=AFPM Paul Fertser wrote: > > > Make use of of_get_ethdev_address() to support reading MAC address no= t > > > only from the usual DT nodes but also from an NVMEM provider (e.g. us= ing > > > a dedicated area in an FRU EEPROM). > >=20 > > Looks like earlier ftgmac100_probe() would move on with self generated > > (random) MAC addr if getting it from the device failed. > > Now you will fail the probe in a failure case. Is that OK? >=20 > I think the previous behaviour is preserved with this patch in all the > cases other than of_get_ethdev_address returning -EPROBE_DEFER. Can > you please explain what failure case you have in mind and how the > probe is going to be failed in that case? FTR, I agree with the above: it looks like the old behavior is preserved. The patch LGTM, thanks! Paolo