From: Martin KaFai Lau <martin.lau@linux.dev>
To: Leon Hwang <leon.hwang@linux.dev>, Feng Yang <yangfeng59949@163.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org, posk@google.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v10 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap
Date: Wed, 4 Mar 2026 17:11:02 -0800 [thread overview]
Message-ID: <682b4e08-7c21-4616-b1cc-65923c3ae09a@linux.dev> (raw)
In-Reply-To: <8f6755ed-d2ae-42ba-8052-2e6fba3d5c69@linux.dev>
On 3/4/26 2:33 AM, Leon Hwang wrote:
> On 4/3/26 17:44, Feng Yang wrote:
>> From: Feng Yang <yangfeng@kylinos.cn>
>>
>> Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
>>
>> Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
>> ---
>> .../selftests/bpf/prog_tests/lwt_misc.c | 9 ++++++++
>> tools/testing/selftests/bpf/progs/lwt_misc.c | 22 +++++++++++++++++++
>> 2 files changed, 31 insertions(+)
>> create mode 100644 tools/testing/selftests/bpf/prog_tests/lwt_misc.c
>> create mode 100644 tools/testing/selftests/bpf/progs/lwt_misc.c
>>
>
> Unnecessary to create new files.
>
> Move the adding test to verifier_lwt.c. prog_tests/verifier.c will run
> the test.
It is actually the change from v9 to v10. I think leaving it separate is
better. It is not testing the verifier, so logically it does not fit in
verifier_lwt.c. It probably won't be the last fix for test_run+lwt, so
separating it should be useful going forward.
next prev parent reply other threads:[~2026-03-05 1:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 9:44 [PATCH v10 bpf-next 0/2] Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap Feng Yang
2026-03-04 9:44 ` [PATCH v10 bpf-next 1/2] bpf: test_run: " Feng Yang
2026-03-04 10:30 ` bot+bpf-ci
2026-03-04 10:33 ` Leon Hwang
2026-03-05 1:12 ` Martin KaFai Lau
2026-03-04 9:44 ` [PATCH v10 bpf-next 2/2] selftests/bpf: Add selftests for the invocation of bpf_lwt_xmit_push_encap Feng Yang
2026-03-04 10:33 ` Leon Hwang
2026-03-05 1:11 ` Martin KaFai Lau [this message]
2026-03-05 1:34 ` Leon Hwang
2026-03-05 1:10 ` [PATCH v10 bpf-next 0/2] Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682b4e08-7c21-4616-b1cc-65923c3ae09a@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=leon.hwang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=posk@google.com \
--cc=yangfeng59949@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox