Re: [PATCH v3 02/19] psp: base PSP device support

[Willem de Bruijn <willemdebruijn.kernel@gmail.com>]

Jakub Kicinski wrote:
> On Sun, 06 Jul 2025 11:31:57 -0400 Willem de Bruijn wrote:
> > > +/**
> > > + * struct psp_dev - PSP device struct
> > > + * @main_netdev: original netdevice of this PSP device
> > > + * @ops:	driver callbacks
> > > + * @caps:	device capabilities
> > > + * @drv_priv:	driver priv pointer
> > > + * @lock:	instance lock, protects all fields
> > > + * @refcnt:	reference count for the instance
> > > + * @id:		instance id
> > > + * @config:	current device configuration
> > > + *
> > > + * @rcu:	RCU head for freeing the structure
> > > + */
> > > +struct psp_dev {
> > > +	struct net_device *main_netdev;
> > > +
> > > +	struct psp_dev_ops *ops;
> > > +	struct psp_dev_caps *caps;
> > > +	void *drv_priv;  
> > 
> > not used?
> 
> I'd rather keep it from the start. The driver-facing API needs to be
> relatively complete otherwise drive authors will work around what's
> missing rather than adding it :(

Sounds good.