From: David Ahern <dsahern@gmail.com>
To: Michal Kubecek <mkubecek@suse.cz>,
"David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Nicolas Dichtel <nicolas.dichtel@6wind.com>,
Tom Herbert <tom@herbertland.com>,
Ido Schimmel <idosch@idosch.org>
Subject: Re: [PATCH net v2] ipv6: omit traffic class when calculating flow hash
Date: Sun, 3 Jun 2018 09:00:42 -0600 [thread overview]
Message-ID: <687af1bc-a1f9-c0d2-dd3a-eeef3a2bf9b4@gmail.com> (raw)
In-Reply-To: <20180602080528.54B27A0C48@unicorn.suse.cz>
On 6/2/18 1:40 AM, Michal Kubecek wrote:
> diff --git a/include/net/ipv6.h b/include/net/ipv6.h
> index 836f31af1369..7fbdc3e9e25d 100644
> --- a/include/net/ipv6.h
> +++ b/include/net/ipv6.h
> @@ -906,6 +906,11 @@ static inline __be32 ip6_make_flowinfo(unsigned int tclass, __be32 flowlabel)
> return htonl(tclass << IPV6_TCLASS_SHIFT) | flowlabel;
> }
>
> +static inline u32 flowi6_get_flowlabel(const struct flowi6 *fl6)
> +{
> + return (__force u32)(fl6->flowlabel & IPV6_FLOWLABEL_MASK);
> +}
> +
> /*
> * Prototypes exported by ipv6
> */
discussing the fix for net-next and making the label vs info consistent,
Michal notes a few places where this helper is needed as a __be32, so
the typecast should be outside of this helper.
next prev parent reply other threads:[~2018-06-03 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-02 7:40 [PATCH net v2] ipv6: omit traffic class when calculating flow hash Michal Kubecek
2018-06-02 9:39 ` Ido Schimmel
2018-06-02 20:33 ` David Ahern
2018-06-03 15:00 ` David Ahern [this message]
2018-06-04 9:36 ` [PATCH net v3] " Michal Kubecek
2018-06-04 17:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=687af1bc-a1f9-c0d2-dd3a-eeef3a2bf9b4@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).