From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: Re: [PATCH net-next] selftests: net: Skip test if IPv6 is not configured
Date: Fri, 25 Jul 2025 17:11:48 -0400 [thread overview]
Message-ID: <6883f3146d073_d14929462@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250725135856.6854f2a5@kernel.org>
Jakub Kicinski wrote:
> On Fri, 25 Jul 2025 16:47:54 -0400 Willem de Bruijn wrote:
> > Less opinionated: the tests implicitly depends on the config files
> > in the test directory. Do we have to start making the robust against
> > situations where CONFIGs in that file are missing?
>
> I was considering adding something like this to the test guidance.
>
> ### Ensure necessary kernel config knobs are set
>
> Each test directory has a `config` file listing which kernel
> configuration options the tests depend on. This file must be kept
> up to date, our CIs build minimal kernels for each test group.
>
> Adding checks inside the tests to validate that the necessary kernel
> configs are enabled is discouraged. The test author may include such
> checks, but standalone patches to make tests compatible e.g. with
> distro kernel configs are unlikely to be accepted.
>
> WDYT?
>
> Primarily trying to minimize the number of patches and adjustments
> we'd see, as the matrix of systems and kernel configs can easily get
> out of hand..
This is great!
It's not really feasible to maintain tests with arbitrary missing
dependencies.
next prev parent reply other threads:[~2025-07-25 21:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-23 17:35 [PATCH net-next] selftests: net: Skip test if IPv6 is not configured Breno Leitao
2025-07-24 20:13 ` Simon Horman
2025-07-25 1:24 ` Jakub Kicinski
2025-07-25 8:11 ` Breno Leitao
2025-07-25 20:47 ` Willem de Bruijn
2025-07-25 20:58 ` Jakub Kicinski
2025-07-25 21:11 ` Willem de Bruijn [this message]
2025-07-25 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6883f3146d073_d14929462@willemb.c.googlers.com.notmuch \
--to=willemdebruijn.kernel@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).