Re: [PATCH v17 03/22] cxl: Move pci generic code

[<dan.j.williams@intel.com>]

alejandro.lucero-palau@ wrote:
> From: Alejandro Lucero <alucerop@amd.com>
> 
> Inside cxl/core/pci.c there are helpers for CXL PCIe initialization
> meanwhile cxl/pci.c implements the functionality for a Type3 device
> initialization.
> 
> Move helper functions from cxl/pci.c to cxl/core/pci.c in order to be
> exported and shared with CXL Type2 device initialization.
> 
> Fix cxl mock tests affected by the code move.

Next time would be nice to have a bit more color commentary on "fixes".
In this case the code was just deleted to address a compilation problem,
but that deletion is ok because this function stopped being called back
in commit 733b57f262b0 ("cxl/pci: Early setup RCH dport component
registers from RCRB").

> 
> Signed-off-by: Alejandro Lucero <alucerop@amd.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Ben Cheatham <benjamin.cheatham@amd.com>
> Reviewed-by: Fan Ni <fan.ni@samsung.com>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>

Reviewed-by still stands, but I question why is_cxl_restricted() needs
to be promoted to a global scope function. Are there going to be RCD
type-2 devices that will have Linux drivers?