From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 768A9C54EE9 for ; Tue, 13 Sep 2022 17:07:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232434AbiIMRHr (ORCPT ); Tue, 13 Sep 2022 13:07:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232165AbiIMRHP (ORCPT ); Tue, 13 Sep 2022 13:07:15 -0400 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C70348FD45; Tue, 13 Sep 2022 08:56:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1663084516; cv=none; d=zohomail.com; s=zohoarc; b=ZNzr5cS4PoJX7wrZG10Q6TWliR6BgVKQGmJuJp6wuGoslH4+TGng3s7jrnaGjRAjmw8Cqce1vIQesxOOuRys2c0xIjKoLqD8VIMI/z+Vvyk5fPOiUOmyaF0lNPgGlxgta20Z8p6bP6V72G/cE7GGwKAkmtO2rsN821TMmut9+Po= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663084516; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=UXdtqi6HBBB/B8fCTaBiJara3bZ6zFCee1eqkkfM+Lc=; b=hcfi3ncwg7YEepO9spUIwS0TzNYzpTjD7lhEM6GdDYCcD3xuGxEiCg/BISASXeVTIno+/zSHDRLI2e1tOD+E1WstQ2nY0p8hxcHU++1J9mBqwvpjZp+q7XJqOKNDL4d4uA3KtqXh6FT8hfVyDsBcZmh/Q4eke3eKPE8LxGDjt88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1663084516; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=UXdtqi6HBBB/B8fCTaBiJara3bZ6zFCee1eqkkfM+Lc=; b=Rbar/MDmOBryUQ8XdW0t8OZeH1xMp9m57JRXhs5Ql7oy9JFxA4Gmtr6nBPgfJo8M dMRrOpaoHgxk3W5qOgIb02mEPXxdKfV9OAZXuzxB2cL/BF2Btq526hRzzuSrGruYGDd Tg1ed8yk6TOc5UguU++CudJuGlqe87qZvKo9iTAk= Received: from [10.10.10.3] (37.120.152.236 [37.120.152.236]) by mx.zohomail.com with SMTPS id 1663084512771268.36068470563725; Tue, 13 Sep 2022 08:55:12 -0700 (PDT) Message-ID: <68902e34-8ef4-994b-8e89-d42b55aeaaec@arinc9.com> Date: Tue, 13 Sep 2022 18:55:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: mt7530: replace label = "cpu" with proper checks Content-Language: en-US To: Vladimir Oltean , netdev@vger.kernel.org Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , George McCollister , Kurt Kanzenbach , Matthias Brugger , Woojung Huh , UNGLinuxDriver@microchip.com, Linus Walleij , =?UTF-8?Q?Alvin_=c5=a0ipraga?= , =?UTF-8?B?Q2zDqW1lbnQgTMOpZ2Vy?= , Landen Chao , DENG Qingfang , Sean Wang , Marek Vasut , John Crispin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org References: <20220912175058.280386-1-vladimir.oltean@nxp.com> <20220912175058.280386-2-vladimir.oltean@nxp.com> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: <20220912175058.280386-2-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12.09.2022 20:50, Vladimir Oltean wrote: > The fact that some DSA device trees use 'label = "cpu"' for the CPU port > is nothing but blind cargo cult copying. The 'label' property was never > part of the DSA DT bindings for anything except the user ports, where it > provided a hint as to what name the created netdevs should use. > > DSA does use the "cpu" port label to identify a CPU port in dsa_port_parse(), > but this is only for non-OF code paths (platform data). > > The proper way to identify a CPU port is to look at whether the > 'ethernet' phandle is present. > > Signed-off-by: Vladimir Oltean I realised "dt-bindings: net: dsa: mt7530:" prefix is used here instead of the usual "dt-bindings: net: dsa: mediatek,mt7530:". Does this matter? Arınç