netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xin Zhao <jackzxcui1989@163.com>,
	 willemdebruijn.kernel@gmail.com,  edumazet@google.com,
	 ferenc@fejes.dev
Cc: davem@davemloft.net,  kuba@kernel.org,  pabeni@redhat.com,
	 horms@kernel.org,  netdev@vger.kernel.org,
	 linux-kernel@vger.kernel.org,  Xin Zhao <jackzxcui1989@163.com>
Subject: Re: [PATCH] net: af_packet: Use hrtimer to do the retire operation
Date: Sat, 09 Aug 2025 09:45:16 -0400	[thread overview]
Message-ID: <689750ec91ef7_2ad372294d8@willemb.c.googlers.com.notmuch> (raw)
In-Reply-To: <20250809124313.1677945-1-jackzxcui1989@163.com>

Xin Zhao wrote:
> In a system with high real-time requirements, the timeout mechanism of
> ordinary timers with jiffies granularity is insufficient to meet the
> demands for real-time performance. Meanwhile, the optimization of CPU
> usage with af_packet is quite significant. Use hrtimer instead of timer
> to help compensate for the shortcomings in real-time performance.
> In HZ=100 or HZ=250 system, the update of TP_STATUS_USER is not real-time
> enough, with fluctuations reaching over 8ms (on a system with HZ=250).
> This is unacceptable in some high real-time systems that require timely
> processing of network packets. By replacing it with hrtimer, if a timeout
> of 2ms is set, the update of TP_STATUS_USER can be stabilized to within
> 3 ms.
> 
> Signed-off-by: Xin Zhao <jackzxcui1989@163.com>

This is a resubmit of the patch you yesterday [1]? While the
discussion on the original patch was ongoing too.

Net-next is also closed. See also see also
Documentation/process/maintainer-netdev.rst for the process.

I'll take a closer look later. Agreed in principle that it's
preferable to replace timer with hrtimer than to add a CONFIG to
select between them.

[1] https://lore.kernel.org/netdev/20250808032623.11485-1-jackzxcui1989@163.com/

  reply	other threads:[~2025-08-09 13:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-09 12:43 [PATCH] net: af_packet: Use hrtimer to do the retire operation Xin Zhao
2025-08-09 13:45 ` Willem de Bruijn [this message]
2025-08-11 14:48 ` Willem de Bruijn
  -- strict thread matches above, loose matches on Subject: below --
2025-08-09 14:44 Xin Zhao
2025-08-12 17:04 Xin Zhao
2025-08-15  2:54 Xin Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=689750ec91ef7_2ad372294d8@willemb.c.googlers.com.notmuch \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ferenc@fejes.dev \
    --cc=horms@kernel.org \
    --cc=jackzxcui1989@163.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).