From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: Re: [PATCH net-next 2/2] net: dsa :mv88e6xxx: Disable unused ports
Date: Fri, 3 May 2019 10:27:56 -0700 [thread overview]
Message-ID: <68b44a04-c6b5-ca39-1322-196cc4c153ea@gmail.com> (raw)
In-Reply-To: <20190430220831.19505-3-andrew@lunn.ch>
On 4/30/19 3:08 PM, Andrew Lunn wrote:
> If the NO_CPU strap is set, the switch starts in 'dumb hub' mode, with
> all ports enable. Ports which are then actively used are reconfigured
> as required when the driver starts. However unused ports are left
> alone. Change this to disable them, and turn off any SERDES
> interface. This could save some power and so reduce the temperature a
> bit.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2019-05-03 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 22:08 [PATCH net-next 0/2] mv88e6xxx: Disable ports to save power Andrew Lunn
2019-04-30 22:08 ` [PATCH net-next 1/2] net: dsa: mv88e6xxx: Set STP disable state in port_disable Andrew Lunn
2019-05-03 14:18 ` Vivien Didelot
2019-05-03 17:27 ` Florian Fainelli
2019-04-30 22:08 ` [PATCH net-next 2/2] net: dsa :mv88e6xxx: Disable unused ports Andrew Lunn
2019-05-03 14:18 ` Vivien Didelot
2019-05-03 17:27 ` Florian Fainelli [this message]
2019-05-04 3:54 ` [PATCH net-next 0/2] mv88e6xxx: Disable ports to save power David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b44a04-c6b5-ca39-1322-196cc4c153ea@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).