From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00513C32750 for ; Wed, 14 Aug 2019 00:22:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D275E20665 for ; Wed, 14 Aug 2019 00:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726555AbfHNAWV (ORCPT ); Tue, 13 Aug 2019 20:22:21 -0400 Received: from mga04.intel.com ([192.55.52.120]:13153 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726007AbfHNAWV (ORCPT ); Tue, 13 Aug 2019 20:22:21 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 17:22:21 -0700 X-IronPort-AV: E=Sophos;i="5.64,382,1559545200"; d="scan'208";a="167220997" Received: from tsduncan-ubuntu.jf.intel.com (HELO [10.7.169.130]) ([10.7.169.130]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/AES256-SHA; 13 Aug 2019 17:22:20 -0700 Subject: Re: [PATCH net-next] net/ncsi: allow to customize BMC MAC Address offset From: Terry Duncan To: Tao Ren Cc: Andrew Lunn , Jakub Kicinski , "netdev@vger.kernel.org" , "openbmc@lists.ozlabs.org" , Ben Wei , "linux-kernel@vger.kernel.org" , Samuel Mendoza-Jonas , "David S.Miller" , William Kennington References: <20190807002118.164360-1-taoren@fb.com> <20190807112518.644a21a2@cakuba.netronome.com> <20190807184143.GE26047@lunn.ch> <806a76a8-229a-7f24-33c7-2cf2094f3436@fb.com> <20190808133209.GB32706@lunn.ch> <77762b10-b8e7-b8a4-3fc0-e901707a1d54@fb.com> <20190808211629.GQ27917@lunn.ch> <20190808230312.GS27917@lunn.ch> <10079A1AC4244A41BC7939A794B72C238FCE0E03@fmsmsx104.amr.corp.intel.com> <33e3e783-fb93-e628-8baa-a8374540ea25@linux.intel.com> Message-ID: <68c25963-4659-c5a2-f8ca-ee51ae17d63f@linux.intel.com> Date: Tue, 13 Aug 2019 17:22:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <33e3e783-fb93-e628-8baa-a8374540ea25@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/13/19 1:54 PM, Terry Duncan wrote: > > On 8/13/19 11:28 AM, Tao Ren wrote: >> On 8/13/19 9:31 AM, Terry Duncan wrote: >>> Tao, in your new patch will it be possible to disable the setting of >>> the BMC MAC?  I would like to be able to send NCSI_OEM_GET_MAC >>> perhaps with netlink (TBD) to get the system address without it >>> affecting the BMC address. >>> >>> I was about to send patches to add support for the Intel adapters >>> when I saw this thread. >>> >>> Thanks, >>> >>> Terry >> >> Hi Terry, >> >> Sounds like you are planning to configure BMC MAC address from user >> space via netlink? Ben Wei started a thread >> "Out-of-band NIC management" in openbmc community for NCSI management >> using netlink, and you may follow up with him for details. >> >> I haven't decided what to do in my v2 patch: maybe using device tree, >> maybe moving the logic to uboot, and I'm also evaluating the netlink >> option. But it shouldn't impact your patch, because you can disable >> NCSI_OEM_GET_MAC option from your config file. > > Thanks Tao. I see now that disabling the NCSI_OEM_GET_MAC option will do > what I want. > > Best, > Terry Hi Tao, After a second look, it appears that the OEM handlers for Broadcom and Melanox in ncsi-rsp.c will set the MAC regardless of the origin of the request. Even with NCSI_OEM_GET_MAC disabled, sending an OEM command with netlink would result in setting the BMC MAC. Thanks, Terry