From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B48E839F172 for ; Tue, 12 May 2026 08:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576197; cv=none; b=pLAUcPMuK5LIM3B1B9Fs33dyEfCuSsEFId6JGBJbr7VNOWTg0rYw1/I7rBP/aOijboOcyQIDQFjKrCpUjgeckqW2IASrxCEmOAo471IamFPDv/XHx4ApiOK/JTRjHOB+9wLjrNSsnXxI3s6fkeeHRyEU3XRPzuqtf20TVzKmL/w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778576197; c=relaxed/simple; bh=lVMwC1V5ByzC5YxGojjAZqoYBJ1DbnrMHPhYH2hoMro=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TRiqgDfiXTZyqITbfkodiQis62TnnKVE4+ZDp5X0xzdfwyMxwwHaO1GDH6Zk6pSw6YvBbnv9rigQpqHUPh9QS2uS2UNXxoOZmHhtPmTUOrPZBdfcSh0GIT5Z0UdXfCVbjvja/VueZCVMNMQ1z4DkODSlntVUkddr1Kq/7Up6esI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=El2hDXb1; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=oABKDu10; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="El2hDXb1"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="oABKDu10" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778576183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=El2hDXb1tRq3Mm0m2CR6xxOobVJEDGZ02R4n5pgSmp6fWmpRqd97a+VYx2FvXBfgUSvtP2 KMYSbS7LUrziV/6aqHRWiLNSSzOOa+DeFwy/U4vnUrMH1AO5WLa6QDqTAVWl2eRj0zjz82 /wFsaOOSOYqt4kGKeXwir2tELP+BObI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-508-GGeFcHucM0mCTNgepaZ74A-1; Tue, 12 May 2026 04:56:20 -0400 X-MC-Unique: GGeFcHucM0mCTNgepaZ74A-1 X-Mimecast-MFC-AGG-ID: GGeFcHucM0mCTNgepaZ74A_1778576180 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-486fa07f2bbso31619715e9.2 for ; Tue, 12 May 2026 01:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778576179; x=1779180979; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=oABKDu10ErJnGkAQrUqCPq6h2GgJFHRZ76/h2KaNkhIiJAm+dA5k/MbjFpy04YZgFh SEwj7Wb0ctLVwXqu5i7Tq09uYEhlNIP2YQLfHSwoy4a+rzttwFTjU3bicLaBgPVLWU58 dUZEgYDwQBi9dt8EIBq3ft3jRj7qxqz5PggFipmG91to3pZjyUbix7HnflJPCZoj97jo 4YRoemJZVfia/VgLeNlgQX7w0r/AxqrFNROYDtNr/WpqKbJnWMGujbbQcGR40psPVfcI UuUZxEW5zAp/MSIURn3j0q2SNz86GQV/UiV5XHWGIhykY2Pg7KxwsqwVPwyRqT8/oOes f6RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778576179; x=1779180979; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gkWWhDNAFlws8ghp7HprrN6Kh7iuwdnJHBkxYwkQhoI=; b=hx4ackp8xkUNIcevrKMxT+ac1vlipm8i5Z/ZO3j0V/6avP9P/OCCnZzJI9xxoO8+Bo inWnX4IxIupdcssuTl0E4AJzP5myCgY21RyjzTQyYjDgJux58w4Y9LNXZ7me1+4Qwl36 /mXyXEt7Fxn6mVaDbs8Xkrgk1xNQvldqN9uWqu/T2xTzcVQqQIpqg30KSIDorJZdq43p QN2AU7206YArxSHgQ1UdPZcNYwBUPsarGO40wtS/LY2GF2PlFmDPiuZaH0KHTDlxlsYX 2SGnQoINigaGCfqX2goXeSikMWIMoTqsQYNFGprH1ivcsd7JYwhirvPgBwORR2gjWOFD 6wMg== X-Forwarded-Encrypted: i=1; AFNElJ8Vsgs44QvBtQW4aTJyrpUVYaAbEivlQa+K8iZMBzmGk2RPfRS2hGTbUWZaFHVtQd6BI/gkVd0=@vger.kernel.org X-Gm-Message-State: AOJu0YySjG2jnqLVoq1SbMN/CBbLo8DoL/pSwfMOdidfN3H5cDRSoPek 1toz96taZX3MunkMhMykg+WM902bub/Nd0DrxePPwA+xcYqs+gGISLdS/TVjU7XfCZQAU9WMKKV UT6QpGDE3c15xp5IYPKZJ4UWm24mObItClXoVmtyE0t1z5AQCkt9j59fy0A== X-Gm-Gg: Acq92OGn2c73W3LO5ObxBDW33XF9wAAeyZbJZP5doamjPDz6hJf/C19pIW0BR7UNNAT p7jaIszs5GHyLjziMn0NEYZssMaw95159dSHSdZZiQrVBy8HR7wGJE0+MXaTe6+RXDB65FK5BtF wvhS+Iihf75QlvCiQPxXeUwOtYfBftc7VLR7CqeS2CJXXM8Frj5HeI8alFCJfGzixWaPsA0e9TD 20e2/JTtlmGXrd+2QmiKgzTsDy93cBGidrL2nwDtT2XyznbmBSagHYVMqjrpU/ZaEPFta6Df9Z5 bUqnUCWbatnquROPOA/cBXrZu7zbfkStm8wDoofbPzFPZN1Gsu6BqP+Qzs9DPEipz04EbSO4QDv 7pxlTZZE9dSfaAJ//0tHfSmKO71PUDf03YTV/RnQDMOs682Ko/bPiQdE= X-Received: by 2002:a05:600c:c058:b0:48a:599a:3716 with SMTP id 5b1f17b1804b1-48e8fe7fa6fmr21523865e9.23.1778576179606; Tue, 12 May 2026 01:56:19 -0700 (PDT) X-Received: by 2002:a05:600c:c058:b0:48a:599a:3716 with SMTP id 5b1f17b1804b1-48e8fe7fa6fmr21523595e9.23.1778576179172; Tue, 12 May 2026 01:56:19 -0700 (PDT) Received: from [192.168.88.32] ([216.128.9.106]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e90536122sm33619495e9.4.2026.05.12.01.56.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 01:56:18 -0700 (PDT) Message-ID: <68e44a69-aeef-4681-8155-7e65e2eb5629@redhat.com> Date: Tue, 12 May 2026 10:56:17 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 2/2] net: dsa: yt921x: Add port TBF support To: David Yang , netdev@vger.kernel.org Cc: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jamal Hadi Salim , Jiri Pirko , Simon Horman , linux-kernel@vger.kernel.org References: <20260508065757.2566258-1-mmyangfl@gmail.com> <20260508065757.2566258-3-mmyangfl@gmail.com> From: Paolo Abeni Content-Language: en-US In-Reply-To: <20260508065757.2566258-3-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/8/26 8:57 AM, David Yang wrote: > @@ -1378,6 +1390,70 @@ yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port, > return res; > } > > +static int > +yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port, > + const struct tc_tbf_qopt_offload *qopt) > +{ > + struct yt921x_priv *priv = to_yt921x_priv(ds); > + struct netlink_ext_ack *extack = qopt->extack; > + u32 ctrls[2]; > + int res; > + > + if (qopt->parent != TC_H_ROOT) > + return -EOPNOTSUPP; > + > + switch (qopt->command) { > + case TC_TBF_STATS: > + return 0; The above makes the stats actually not supported; it should return -NOPNOTSUPP. /P