From: "Vladimir Nikishkin" <vladimir@nikishkin.pw>
To: "Stephen Hemminger" <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com,
eng.alaamohamedsoliman.am@gmail.com, gnault@redhat.com,
razor@blackwall.org, idosch@nvidia.com, liuhangbin@gmail.com,
eyal.birger@gmail.com, jtoppins@redhat.com
Subject: Re: [PATCH iproute2-next v6] ip-link: add support for nolocalbypass in vxlan
Date: Wed, 24 May 2023 00:11:22 +0800 [thread overview]
Message-ID: <68f22fdf-8157-4eb9-a658-9962befab54c@app.fastmail.com> (raw)
In-Reply-To: <20230523090441.5a68d0db@hermes.local>
On Wed, May 24, 2023, at 00:04, Stephen Hemminger wrote:
> On Tue, 23 May 2023 12:48:05 +0800
> Vladimir Nikishkin <vladimir@nikishkin.pw> wrote:
>
>> + if (tb[IFLA_VXLAN_LOCALBYPASS]) {
>> + __u8 localbypass = rta_getattr_u8(tb[IFLA_VXLAN_LOCALBYPASS]);
>> +
>> + print_bool(PRINT_JSON, "localbypass", NULL, localbypass);
>> + if (!localbypass)
>> + print_bool(PRINT_FP, NULL, "nolocalbypass ", true);
>> + }
>
> This is backwards since nolocalbypass is the default.
localbypass is (or should) be the default, because it is how everything used to work in the past. nolocalbypass is the new feature.
--
Fastmail.
next prev parent reply other threads:[~2023-05-23 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 4:48 [PATCH iproute2-next v6] ip-link: add support for nolocalbypass in vxlan Vladimir Nikishkin
2023-05-23 16:04 ` Stephen Hemminger
2023-05-23 16:11 ` Vladimir Nikishkin [this message]
2023-05-23 18:37 ` Andrea Claudi
2023-05-23 22:23 ` Stephen Hemminger
2023-05-25 8:08 ` Vladimir Nikishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f22fdf-8157-4eb9-a658-9962befab54c@app.fastmail.com \
--to=vladimir@nikishkin.pw \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eng.alaamohamedsoliman.am@gmail.com \
--cc=eyal.birger@gmail.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=jtoppins@redhat.com \
--cc=kuba@kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).