From: Eric Dumazet <eric.dumazet@gmail.com>
To: Dimitris Michailidis <dmichail@google.com>
Cc: "Cong Wang" <xiyou.wangcong@gmail.com>,
"Paweł Staszewski" <pstaszewski@itcare.pl>,
"Linux Kernel Network Developers" <netdev@vger.kernel.org>
Subject: Re: Latest net-next kernel 4.19.0+
Date: Tue, 30 Oct 2018 00:29:13 -0700 [thread overview]
Message-ID: <68f25a28-b79e-d3ae-6eef-50c354ad63ae@gmail.com> (raw)
In-Reply-To: <CAG76SjY7fnFdgamBELATyO8NGnyNFYiX33SgLE6-q=eoBM8jKg@mail.gmail.com>
On 10/29/2018 11:09 PM, Dimitris Michailidis wrote:
>
> Indeed this is a bug. I would expect it to produce frequent errors
> though as many odd-length
> packets would trigger it. Do you have RXFCS? Regardless, how
> frequently do you see the problem?
>
Old kernels (before 88078d98d1bb) were simply resetting ip_summed to CHECKSUM_NONE
And before your fix (commit d55bef5059dd057bd), mlx5 bug was canceling the bug you fixed.
So we now need to also fix mlx5.
And of course use skb_header_pointer() in mlx5e_get_fcs() as I mentioned earlier,
plus __get_unaligned_cpu32() as you hinted.
next prev parent reply other threads:[~2018-10-30 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-30 0:10 Latest net-next kernel 4.19.0+ Paweł Staszewski
2018-10-30 0:11 ` Paweł Staszewski
2018-10-30 0:34 ` Paweł Staszewski
2018-10-30 2:27 ` Cong Wang
2018-10-30 2:43 ` Cong Wang
2018-10-30 2:53 ` Eric Dumazet
2018-10-30 3:52 ` Eric Dumazet
2018-10-30 6:09 ` Dimitris Michailidis
2018-10-30 7:29 ` Eric Dumazet [this message]
2018-10-30 8:09 ` Paweł Staszewski
2018-10-30 14:16 ` Eric Dumazet
2018-10-30 17:32 ` Cong Wang
2018-10-30 17:50 ` Eric Dumazet
2018-10-30 17:54 ` Cong Wang
2018-10-31 21:05 ` Saeed Mahameed
2018-10-31 21:17 ` Cong Wang
2018-11-01 22:59 ` Paweł Staszewski
2018-11-08 18:35 ` Cong Wang
2018-10-31 21:22 ` Paweł Staszewski
2018-10-31 21:24 ` Paweł Staszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f25a28-b79e-d3ae-6eef-50c354ad63ae@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=dmichail@google.com \
--cc=netdev@vger.kernel.org \
--cc=pstaszewski@itcare.pl \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).