[PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Tariq Toukan]

From: Yael Chemla <ychemla@nvidia.com>

Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
usage in ethtool and link-info tables.

Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Signed-off-by: Yael Chemla <ychemla@nvidia.com>
Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/infiniband/hw/mlx5/main.c                    | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +-
 drivers/net/ethernet/mellanox/mlx5/core/port.c       | 2 +-
 include/linux/mlx5/port.h                            | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index 40284bbb45d6..947faacd75bb 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -511,7 +511,7 @@ static int translate_eth_ext_proto_oper(u32 eth_proto_oper, u16 *active_speed,
 		*active_width = IB_WIDTH_4X;
 		*active_speed = IB_SPEED_XDR;
 		break;
-	case MLX5E_PROT_MASK(MLX5E_1600TAUI_8_1600TBASE_CR8_KR8):
+	case MLX5E_PROT_MASK(MLX5E_1600GAUI_8_1600GBASE_CR8_KR8):
 		*active_width = IB_WIDTH_8X;
 		*active_speed = IB_SPEED_XDR;
 		break;
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
index d3fef1e7e2f7..4a8dc85d5924 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
@@ -261,7 +261,7 @@ void mlx5e_build_ptys2ethtool_map(void)
 				       ETHTOOL_LINK_MODE_800000baseDR4_2_Full_BIT,
 				       ETHTOOL_LINK_MODE_800000baseSR4_Full_BIT,
 				       ETHTOOL_LINK_MODE_800000baseVR4_Full_BIT);
-	MLX5_BUILD_PTYS2ETHTOOL_CONFIG(MLX5E_1600TAUI_8_1600TBASE_CR8_KR8, ext,
+	MLX5_BUILD_PTYS2ETHTOOL_CONFIG(MLX5E_1600GAUI_8_1600GBASE_CR8_KR8, ext,
 				       ETHTOOL_LINK_MODE_1600000baseCR8_Full_BIT,
 				       ETHTOOL_LINK_MODE_1600000baseKR8_Full_BIT,
 				       ETHTOOL_LINK_MODE_1600000baseDR8_Full_BIT,
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/port.c b/drivers/net/ethernet/mellanox/mlx5/core/port.c
index e8a0884ea477..181714d37776 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/port.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/port.c
@@ -1111,7 +1111,7 @@ mlx5e_ext_link_info[MLX5E_EXT_LINK_MODES_NUMBER] = {
 	[MLX5E_200GAUI_1_200GBASE_CR1_KR1]	= {.speed = 200000, .lanes = 1},
 	[MLX5E_400GAUI_2_400GBASE_CR2_KR2]	= {.speed = 400000, .lanes = 2},
 	[MLX5E_800GAUI_4_800GBASE_CR4_KR4]	= {.speed = 800000, .lanes = 4},
-	[MLX5E_1600TAUI_8_1600TBASE_CR8_KR8]	= {.speed = 1600000, .lanes = 8},
+	[MLX5E_1600GAUI_8_1600GBASE_CR8_KR8]	= {.speed = 1600000, .lanes = 8},
 };
 
 int mlx5_port_query_eth_proto(struct mlx5_core_dev *dev, u8 port, bool ext,
diff --git a/include/linux/mlx5/port.h b/include/linux/mlx5/port.h
index 1df9d9a57bbc..12d366b12e2e 100644
--- a/include/linux/mlx5/port.h
+++ b/include/linux/mlx5/port.h
@@ -112,7 +112,7 @@ enum mlx5e_ext_link_mode {
 	MLX5E_400GAUI_2_400GBASE_CR2_KR2	= 17,
 	MLX5E_800GAUI_8_800GBASE_CR8_KR8	= 19,
 	MLX5E_800GAUI_4_800GBASE_CR4_KR4	= 20,
-	MLX5E_1600TAUI_8_1600TBASE_CR8_KR8	= 23,
+	MLX5E_1600GAUI_8_1600GBASE_CR8_KR8	= 23,
 	MLX5E_EXT_LINK_MODES_NUMBER,
 };
 

base-commit: 9a9424c756feee9ee6e717405a9d6fa7bacdef08
-- 
2.44.0

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Jacob Keller]

On 2/4/2026 11:43 AM, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@nvidia.com>
> 
> Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
> usage in ethtool and link-info tables.
> 
> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Dawid Osuchowski]

On 2026-02-04 8:43 PM, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@nvidia.com>
> 
> Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
> usage in ethtool and link-info tables.
> 
> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---

Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>

Checkpatch is complaining:

------

scripts/checkpatch.pl --strict 
20260204_tariqt_net_mlx5_fix_1600g_link_mode_enum_naming.mbx
WARNING: Reported-by: should be immediately followed by Closes: with a 
URL to the report
#13:
Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Signed-off-by: Yael Chemla <ychemla@nvidia.com>

total: 0 errors, 1 warnings, 0 checks, 32 lines checked

------

But I raised this off-list, so that's fine :)

Thanks,
Dawid

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Jakub Kicinski]

On Thu, 5 Feb 2026 13:42:16 +0100 Dawid Osuchowski wrote:
> WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report

FTR netdev ignores this warning.

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Leon Romanovsky]

On Wed, Feb 04, 2026 at 09:43:24PM +0200, Tariq Toukan wrote:
> From: Yael Chemla <ychemla@nvidia.com>
> 
> Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
> usage in ethtool and link-info tables.
> 
> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
>  drivers/infiniband/hw/mlx5/main.c                    | 2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c | 2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/port.c       | 2 +-
>  include/linux/mlx5/port.h                            | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 4 Feb 2026 21:43:24 +0200 you wrote:
> From: Yael Chemla <ychemla@nvidia.com>
> 
> Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
> usage in ethtool and link-info tables.
> 
> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net/mlx5: Fix 1600G link mode enum naming
    https://git.kernel.org/netdev/net-next/c/215b53099b60

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Dawid Osuchowski]

On 2026-02-06 3:50 AM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to netdev/net-next.git (main)
> by Jakub Kicinski <kuba@kernel.org>:
> 
> On Wed, 4 Feb 2026 21:43:24 +0200 you wrote:
>> From: Yael Chemla <ychemla@nvidia.com>
>>
>> Rename TAUI/TBASE to GAUI/GBASE in 1600G link mode identifier and its
>> usage in ethtool and link-info tables.
>>
>> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
>> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
>> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
>> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
>>
>> [...]
> 
> Here is the summary with links:
>    - [net-next] net/mlx5: Fix 1600G link mode enum naming
>      https://git.kernel.org/netdev/net-next/c/215b53099b60
> 
> You are awesome, thank you!

Hey Kuba,

I noticed that in the commit message on the net-next tree the following 
tags are duplicated:

Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
Signed-off-by: Yael Chemla <ychemla@nvidia.com>

Is that by design or did the bot break something? This is purely out of 
my curiosity.

Best regards,
Dawid

Re: [PATCH net-next] net/mlx5: Fix 1600G link mode enum naming

[Jakub Kicinski]

On Fri, 6 Feb 2026 11:48:58 +0100 Dawid Osuchowski wrote:
> > Here is the summary with links:
> >    - [net-next] net/mlx5: Fix 1600G link mode enum naming
> >      https://git.kernel.org/netdev/net-next/c/215b53099b60
> > 
> > You are awesome, thank you!  
> 
> Hey Kuba,
> 
> I noticed that in the commit message on the net-next tree the following 
> tags are duplicated:
> 
> Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> 
> Is that by design or did the bot break something? This is purely out of 
> my curiosity.

Oh damn :( This is what patchwork produces:

    Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
    Signed-off-by: Yael Chemla <ychemla@nvidia.com>
    Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
    Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
    Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
    Reviewed-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
    Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
    Signed-off-by: Yael Chemla <ychemla@nvidia.com>
    Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
    Reported-by: Dawid Osuchowski <dawid.osuchowski@linux.intel.com>
    Signed-off-by: Yael Chemla <ychemla@nvidia.com>

I fixed it up manually but clearly not well enough.

Patchwork needs so much work..