From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [bpf-next v2 8/9] bpf: Provide helper to do forwarding lookups in
 kernel FIB table
Date: Wed, 9 May 2018 10:05:56 -0600
Message-ID: <69063df2-8987-b5f1-ced2-b2443139b5a5@gmail.com>
References: <20180504025432.23451-1-dsahern@gmail.com>
 <20180504025432.23451-9-dsahern@gmail.com>
 <433c2320-ed9b-446e-6e29-92075f947251@iogearbox.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: davem@davemloft.net, shm@cumulusnetworks.com,
        roopa@cumulusnetworks.com, brouer@redhat.com, toke@toke.dk,
        john.fastabend@gmail.com
To: Daniel Borkmann <daniel@iogearbox.net>, netdev@vger.kernel.org,
        borkmann@iogearbox.net, ast@kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pg0-f44.google.com ([74.125.83.44]:35686 "EHLO
        mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965368AbeEIQF7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 9 May 2018 12:05:59 -0400
Received: by mail-pg0-f44.google.com with SMTP id n1-v6so364306pgs.2
        for <netdev@vger.kernel.org>; Wed, 09 May 2018 09:05:59 -0700 (PDT)
In-Reply-To: <433c2320-ed9b-446e-6e29-92075f947251@iogearbox.net>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 5/9/18 2:15 AM, Daniel Borkmann wrote:
> 
> Ohh well, this is causing allmodconfig build warnings (e.g. on x86) as reported today:

lovely.

> 
> In file included from include/linux/dma-mapping.h:5:0,
>                  from include/linux/skbuff.h:34,
>                  from include/linux/if_ether.h:23,
>                  from include/uapi/linux/bpf.h:13,
>                  from include/linux/bpf-cgroup.h:6,
>                  from include/linux/cgroup-defs.h:22,
>                  from include/linux/cgroup.h:28,
>                  from include/linux/perf_event.h:57,
>                  from include/linux/trace_events.h:10,
>                  from include/trace/trace_events.h:20,
>                  from include/trace/define_trace.h:96,
>                  from drivers/android/binder_trace.h:387,
>                  from drivers/android/binder.c:5702:
> include/linux/sizes.h:24:0: warning: "SZ_1K" redefined
>  #define SZ_1K    0x00000400
> drivers/android/binder.c:116:0: note: this is the location of the previous definition
>  #define SZ_1K                               0x400

binder.c has very few recent commits to it. Are you ok with me
submitting the change with the others in this set (with proper cc's of
course)?

> fs/ecryptfs/miscdev.c:206:0: warning: "PKT_TYPE_OFFSET" redefined
>  #define PKT_TYPE_OFFSET  0
> In file included from include/linux/if_ether.h:23:0,
>                  from include/uapi/linux/bpf.h:13,
>                  from include/linux/bpf-cgroup.h:6,
>                  from include/linux/cgroup-defs.h:22,
>                  from include/linux/cgroup.h:28,
>                  from include/linux/writeback.h:183,
>                  from include/linux/backing-dev.h:16,
>                  from fs/ecryptfs/ecryptfs_kernel.h:41,
>                  from fs/ecryptfs/miscdev.c:30:
> include/linux/skbuff.h:753:0: note: this is the location of the previous definition
>  #define PKT_TYPE_OFFSET() offsetof(struct sk_buff, __pkt_type_offset)

And this one I renamed to SKB_PKT_TYPE_OFFSET

With that it compiles cleanly.

> 
> Lets get a clean, proper version of the whole series into bpf-next. I've dropped it
> from there right now and waiting for your v3 respin to apply with the above fixed.
> 
> Thank you.
>