netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: Fix error handling in netdev_register_kobject
@ 2025-11-07  8:01 Ma Ke
  2025-11-07 11:06 ` [syzbot ci] " syzbot ci
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Ma Ke @ 2025-11-07  8:01 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, horms, sdf, atenart, kuniyu,
	yajun.deng, gregkh, ebiederm
  Cc: netdev, linux-kernel, akpm, Ma Ke, stable

After calling device_initialize(), the reference count of the device
is set to 1. If device_add() fails or register_queue_kobjects() fails,
the function returns without calling put_device() to release the
initial reference, causing a memory leak of the device structure.
Similarly, in netdev_unregister_kobject(), after calling device_del(),
there is no call to put_device() to release the initial reference,
leading to a memory leak. Add put_device() in the error paths of
netdev_register_kobject() and after device_del() in
netdev_unregister_kobject() to properly release the device references.

Found by code review.

Cc: stable@vger.kernel.org
Fixes: a1b3f594dc5f ("net: Expose all network devices in a namespaces in sysfs")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
---
 net/core/net-sysfs.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c
index ca878525ad7c..d3895f26a0c8 100644
--- a/net/core/net-sysfs.c
+++ b/net/core/net-sysfs.c
@@ -2327,6 +2327,7 @@ void netdev_unregister_kobject(struct net_device *ndev)
 	pm_runtime_set_memalloc_noio(dev, false);
 
 	device_del(dev);
+	put_device(dev);
 }
 
 /* Create sysfs entries for network device. */
@@ -2357,7 +2358,7 @@ int netdev_register_kobject(struct net_device *ndev)
 
 	error = device_add(dev);
 	if (error)
-		return error;
+		goto out_put_device;
 
 	error = register_queue_kobjects(ndev);
 	if (error) {
@@ -2367,6 +2368,10 @@ int netdev_register_kobject(struct net_device *ndev)
 
 	pm_runtime_set_memalloc_noio(dev, true);
 
+	return 0;
+
+out_put_device:
+	put_device(dev);
 	return error;
 }
 
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-12  6:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-07  8:01 [PATCH] net: Fix error handling in netdev_register_kobject Ma Ke
2025-11-07 11:06 ` [syzbot ci] " syzbot ci
2025-11-07 11:20 ` [PATCH] " Eric Dumazet
2025-11-12  5:59 ` kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).