From: "Rangoju, Raju" <raju.rangoju@amd.com>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
pabeni@redhat.com, kuba@kernel.org, edumazet@google.com,
davem@davemloft.net, andrew+netdev@lunn.ch,
Thomas.Lendacky@amd.com
Subject: Re: [PATCH net 1/2] amd-xgbe: fix sleep while atomic on suspend/resume
Date: Thu, 26 Feb 2026 21:09:16 +0530 [thread overview]
Message-ID: <693d8650-8286-42d4-ace7-9cdfcc3ba80e@amd.com> (raw)
In-Reply-To: <aaA_WJaNG03dcAPB@horms.kernel.org>
On 2/26/2026 6:10 PM, Simon Horman wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Wed, Feb 25, 2026 at 04:30:00PM +0530, Raju Rangoju wrote:
>
> ...
>
>> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-pci.c b/drivers/net/ethernet/amd/xgbe/xgbe-pci.c
>
> ...
>
>> @@ -453,7 +453,7 @@ static const struct pci_device_id xgbe_pci_table[] = {
>> };
>> MODULE_DEVICE_TABLE(pci, xgbe_pci_table);
>>
>> -static SIMPLE_DEV_PM_OPS(xgbe_pci_pm_ops, xgbe_pci_suspend, xgbe_pci_resume);
>> +DEFINE_SIMPLE_DEV_PM_OPS(xgbe_pci_pm_ops, xgbe_pci_suspend, xgbe_pci_resume);
>
> Sorry for not noticing this before sending my previous email.
>
> Sparse flags that xgbe_pci_pm_ops should (still) be static.
Noted. Thank you. Will fix it in the clean-up part.
>
>>
>> static struct pci_driver xgbe_driver = {
>> .name = XGBE_DRV_NAME,
>
> ...
next prev parent reply other threads:[~2026-02-26 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 10:59 [PATCH net 0/2] amd-xgbe: fix S0i3 suspend/resume issues Raju Rangoju
2026-02-25 11:00 ` [PATCH net 1/2] amd-xgbe: fix sleep while atomic on suspend/resume Raju Rangoju
2026-02-26 12:37 ` Simon Horman
2026-02-26 15:37 ` Rangoju, Raju
2026-02-26 12:40 ` Simon Horman
2026-02-26 15:39 ` Rangoju, Raju [this message]
2026-02-25 11:00 ` [PATCH net 2/2] amd-xgbe: add PCI power management for S0i3 support Raju Rangoju
2026-02-26 12:38 ` Simon Horman
2026-02-26 15:42 ` Rangoju, Raju
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=693d8650-8286-42d4-ace7-9cdfcc3ba80e@amd.com \
--to=raju.rangoju@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox