From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 325EFC43381 for ; Sat, 2 Mar 2019 02:53:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E86B92075B for ; Sat, 2 Mar 2019 02:53:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f0r/EF1+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727884AbfCBCxz (ORCPT ); Fri, 1 Mar 2019 21:53:55 -0500 Received: from mail-pl1-f176.google.com ([209.85.214.176]:36767 "EHLO mail-pl1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728290AbfCBCxy (ORCPT ); Fri, 1 Mar 2019 21:53:54 -0500 Received: by mail-pl1-f176.google.com with SMTP id k2so12363080plt.3 for ; Fri, 01 Mar 2019 18:53:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=i8cJ9xUCbZ4QfSjRugkrvHlfrcs4Ozm6Wlc6emSQy8U=; b=f0r/EF1+Yvewm0b5OhCtqpLUK/qWlTcYwAPCWTRPcFMt/vhYD9u0ul38xwujpfg0Ff UgcXjj4efZVfQkBrJdxuyW9zF/7ZSEBU8RLtp44H7v4GNcqSpYxvib2FOM7SgzSqlTfY cEs5822HxwQyzj2nWBvhg5/PE6Wy1KRxP3OfIczUBN/nw77XZVl5jVM9c0+EnXJrU0ah vD7QYUhAJb7nx0dJwhe5ty7MH07K8IZP8xND8iTqlvEtTwTW16szapjr8FvmocAhWjoI SJh03QoyOLCSHPrEYGZiVI8+SkOacp+pFOCS0HqKOLLjfiyweIDH1hj0sVBSo0EVVXRg BPBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=i8cJ9xUCbZ4QfSjRugkrvHlfrcs4Ozm6Wlc6emSQy8U=; b=X9Iq9o2jKceZ/8uM972pxYcraFHF9IaVH4Y1AMHm9EioPXD8TtAc+aXdKsL5Wo1ZDd 7LewO1aLraxu+zrh8YBRYfOXULwmMCE9jytthWN/PK7VOB1wBmk4FytmB+8gwDHJTql8 +9ueSm6fWNklIxd0gDZDQuXJ66CbetMfUlZVqycMzBw54EWRG9/S2X0bEDgbbM8ZzqT3 5mrpMindQMrPWDedjcQ1P10pkKIHD0ZuvwurA1J50zPBuXB7lhhfBxlyh+a50OpWlTff H9/9OqXx7/aiEXuaRxXgv6xggSOOuID796rmBCEWTA9QojtAPLK3VkIwKENOfVRAlW9P DyBg== X-Gm-Message-State: APjAAAWm+BFWFMLz44x6xfjEmcRWH9MwsbYabTZy80av1nz1ikBOSayZ fo6OBWb+AgIi2VTRgm5Nrjq0TLKj X-Google-Smtp-Source: APXvYqx7P2FemXq1tL6sDhWU+xxNVzz+qlxgDSb0KW+xKIHb7g61dza/ZqXpSYvh0IjnBFlTkEpLpw== X-Received: by 2002:a17:902:7682:: with SMTP id m2mr8973481pll.311.1551495233235; Fri, 01 Mar 2019 18:53:53 -0800 (PST) Received: from [10.230.26.115] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id i7sm62998711pgp.62.2019.03.01.18.53.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Mar 2019 18:53:52 -0800 (PST) Subject: Re: [patch net-next RFC 2/8] net: devlink: extend port attrs for switch ID To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, mlxsw@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, dirk.vandermerwe@netronome.com, andrew@lunn.ch, vivien.didelot@gmail.com References: <20190301160542.6474-1-jiri@resnulli.us> <20190301160542.6474-3-jiri@resnulli.us> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; keydata= mQENBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAG0KEZsb3JpYW4gRmFpbmVsbGkgPGZhaW5lbGxpQGJyb2FkY29tLmNvbT6JAccEEAECALEF AlPAG9YXCgABv0jL/n0t8VEFmtDa8j7qERo7AN0gFAAAAAAAFgABa2V5LXVzYWdlLW1hc2tA cGdwLmNvbY4wFIAAAAAAIAAHcHJlZmVycmVkLWVtYWlsLWVuY29kaW5nQHBncC5jb21wZ3Bt aW1lCAsJCAcDAgEKAhkBBReAAAAAGRhsZGFwOi8va2V5cy5icm9hZGNvbS5jb20FGwMAAAAD FgIBBR4BAAAABBUICQoACgkQgTG1xCm8ZqD+Dgf9HhhzqvJYIPomNeg+ll7/TbzWb871E+HQ TaufJQFQwLEbgdFSZO2uj4UqfDpCyTwtHTVMJogWt3pCAE1sadeIY8OlT6918ofKIl8AiHj2 BlfL7ASZ5wzkRMt/4TZoinq9O1tPEynb5G6PdZTV3UQtmSGnpt2EOu7KtRJsnThBiXoOO9TJ Asg4vXJ0ZM1y/MPhQlZbPCHQZFe1gaVWBPLGnLyWyeprqgSLWHaGqrUhlfK1sLuJK1bjYDCI NetK0pS4cA4ZJgogr5FrtV64R19zLl02mt/Yj7rAmjC3ZBuwVi3V35kD8Kd4d9QM2apsiILV bzGbtVCSUgvxI+1SsJEm3bkBDQRTwBvBAQgArGvvWip77T4xgJztZp9YRylAcVTC9gtx0Gg6 eYk/EPANGm9TkuGpI++T/Il2H2TjFQNC7eubWohbYj0+6Tmf8nP+VmyobDxPXcMrK7x4xy9o D+Kub2Vf0SXbsM8fL/SqzGbFWZSm73L1L4GZoxvYIz0i7LExYSX2u5YVLaMBaH9HwKt2cvr7 MuTrRHtcbOZImoXT29g2UnoF1uwxYNeRhZY/lRvVkkY0lDipPuDwg3SpfHMtCybPq1uAswQd gEbHzRsEXwCR1OF3pIuGt4I3tSEhH/k1caqi0BlqjbGUOkku44xC2gf1ZU267FBBkdV3yJ/7 KnrJEnkMCYhS3kII9wARAQABiQJBBBgBAgErBQJTwBvCBRsMAAAAwF0gBBkBCAAGBQJTwBvB AAoJEJNgBqiYLw9VDRUIAJaTef6hsUAESnlGDpC+ymL2RZdzAJx9lXjU4hhaFcyhznuyyMJq d3mehmLxsqDRvHDiqyD71w2Bnc838MVZw0pwBPdnb/h9Ocmp0lL/9hwSGWvy4az5lYVyoA9u 14UIzh0YNGu6jr0isd/LJAbHXqwJwWWs3y8PTrpEp68V6lv+aXt5gR03lJEAvIR1Awp4JJ/e Z5y12gQISp0X8xal9YhhDWER92YLYrO2b6Hc2S31lAupzfCw8lmZsP1PRz1GmF/KmDD9J9N/ b8IehhWQqrBQjMjn2K2XkvN75HnAMHKFYfHZR3ZHtK52ZP1crV7THtbtrnPXVDq+vO4QPmdC +SEACgkQgTG1xCm8ZqC6BwgAl3kRh7oozpjpG8jpO8en5CBtTl3G+OpKJK9qbQyzdCsuJ0K1 qe1wZPZbP/Y+VtmqSgnExBzjStt9drjFBK8liPQZalp2sMlS9S7csSy6cMLF1auZubAZEqpm tpXagbtgR12YOo57Reb83F5KhtwwiWdoTpXRTx/nM0cHtjjrImONhP8OzVMmjem/B68NY++/ qt0F5XTsP2zjd+tRLrFh3W4XEcLt1lhYmNmbJR/l6+vVbWAKDAtcbQ8SL2feqbPWV6VDyVKh ya/EEq0xtf84qEB+4/+IjCdOzDD3kDZJo+JBkDnU3LBXw4WCw3QhOXY+VnhOn2EcREN7qdAK w0j9Sw== Message-ID: <6943ae8f-8415-3638-736a-e32a5c157bff@gmail.com> Date: Fri, 1 Mar 2019 18:53:47 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: <20190301160542.6474-3-jiri@resnulli.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/1/2019 8:05 AM, Jiri Pirko wrote: > From: Jiri Pirko > > Extend devlink_port_attrs_set() to pass switch ID for ports which are > part of switch and store it in port attrs. For other ports, this is > NULL. During dump to userspace only valid switch ID is filled up. > Note that this allows the driver to group devlink ports into one or more > switches according to the actual topology. > > Signed-off-by: Jiri Pirko > --- [snip] > @@ -5415,6 +5423,15 @@ void devlink_port_attrs_set(struct devlink_port *devlink_port, > attrs->port_number = port_number; > attrs->split = split; > attrs->split_subport_number = split_subport_number; > + if (switch_id) { > + attrs->switch_port = true; > + if (WARN_ON(switch_id_len > MAX_PHYS_ITEM_ID_LEN)) > + switch_id_len = MAX_PHYS_ITEM_ID_LEN; > + memcpy(attrs->switch_id.id, switch_id, switch_id_len); > + attrs->switch_id.id_len = switch_id_len; > + } else { > + attrs->switch_port = false; Would not switch_id.id_len != 0 be enough of an indicator that this is a switch port? -- Florian