From: "Lena Wang (王娜)" <Lena.Wang@mediatek.com>
To: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"dsahern@kernel.org" <dsahern@kernel.org>,
"edumazet@google.com" <edumazet@google.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Shiming Cheng (成诗明)" <Shiming.Cheng@mediatek.com>
Subject: [PATCH net v2] Net:cache didn't flush when ipv6 rule changed
Date: Wed, 28 Feb 2024 08:24:55 +0000 [thread overview]
Message-ID: <696e39599c7a5e793a9d96aceef0e34817ab0bb2.camel@mediatek.com> (raw)
In-Reply-To: <3efcbaf0872481d1a842eb9e18fa368b4b94d940.camel@mediatek.com>
From bf53859b379a653eec8a14fbb3f29286f9f888fb Mon Sep 17 00:00:00 2001
From: shiming cheng <shiming.cheng@mediatek.com>
Date: Mon, 26 Feb 2024 20:17:58 +0800
Subject: [PATCH net v2] Net:cache didn't flush when ipv6 rule changed
When changed from old rule&route configure to new one as below,
ipv6 cache dst_entry did not change to new route table as no
cache flush callback function, then forward to wrong out interface.
When fib6_check dst_entry, the fib6_node version[fn_sernm] is
always the same with socket dst_cookie, old cache dst_entry is
always used and no chance to update.
So we need to update fib6_node version when rule changed and
flush cache to avoid dispatching a wrong interface.
Signed-off-by: shiming cheng <shiming.cheng@mediatek.com>
---
v2:
1. Add the fix tag.
2. Changes according to David Ahern's suggestions, modify flush
functions same way as ipv4 flush cache and use tabs to aligh with
existing code.
---
---
net/ipv6/fib6_rules.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/ipv6/fib6_rules.c b/net/ipv6/fib6_rules.c
index 7523c4baef35..52c04f0ac498 100644
--- a/net/ipv6/fib6_rules.c
+++ b/net/ipv6/fib6_rules.c
@@ -449,6 +449,11 @@ static size_t fib6_rule_nlmsg_payload(struct
fib_rule *rule)
+ nla_total_size(16); /* src */
}
+static void fib6_rule_flush_cache(struct fib_rules_ops *ops)
+{
+ rt_genid_bump_ipv6(ops->fro_net);
+}
+
static const struct fib_rules_ops __net_initconst
fib6_rules_ops_template = {
.family = AF_INET6,
.rule_size = sizeof(struct fib6_rule),
@@ -461,6 +466,7 @@ static const struct fib_rules_ops __net_initconst
fib6_rules_ops_template = {
.compare = fib6_rule_compare,
.fill = fib6_rule_fill,
.nlmsg_payload = fib6_rule_nlmsg_payload,
+ .flush_cache = fib6_rule_flush_cache,
.nlgroup = RTNLGRP_IPV6_RULE,
.owner = THIS_MODULE,
.fro_net = &init_net,
--
2.18.0
next parent reply other threads:[~2024-02-28 8:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3efcbaf0872481d1a842eb9e18fa368b4b94d940.camel@mediatek.com>
2024-02-28 8:24 ` Lena Wang (王娜) [this message]
2024-02-28 12:30 ` [PATCH net v2] Net:cache didn't flush when ipv6 rule changed Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696e39599c7a5e793a9d96aceef0e34817ab0bb2.camel@mediatek.com \
--to=lena.wang@mediatek.com \
--cc=Shiming.Cheng@mediatek.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox