From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: ggarcia@abra.uab.cat, netdev@vger.kernel.org
Cc: stefanha@redhat.com, mst@redhat.com
Subject: Re: [PATCH 1/1] VSOCK: remove more space available check filling TX vq
Date: Fri, 5 Aug 2016 19:53:46 +0300 [thread overview]
Message-ID: <69d05004-506c-dbc2-f97e-b71f4945c703@cogentembedded.com> (raw)
In-Reply-To: <20160805163420.10092-1-ggarcia@deic.uab.cat>
On 08/05/2016 07:34 PM, ggarcia@abra.uab.cat wrote:
> From: Gerard Garcia <ggarcia@deic.uab.cat>
>
> Remove unnecessary use of enable/disable callback notifications
> and the incorrect more space available check.
>
> The virtio_transport_tx_work handles when the TX virtqueue
> has more buffers available.
>
> Signed-off-by: Gerard Garcia <ggarcia@deic.uab.cat>
> ---
> net/vmw_vsock/virtio_transport.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/net/vmw_vsock/virtio_transport.c b/net/vmw_vsock/virtio_transport.c
> index 699dfab..b7a1055 100644
> --- a/net/vmw_vsock/virtio_transport.c
> +++ b/net/vmw_vsock/virtio_transport.c
[...]
> @@ -118,13 +114,12 @@ virtio_transport_send_pkt_work(struct work_struct *work)
> }
>
> ret = virtqueue_add_sgs(vq, sgs, out_sg, in_sg, pkt, GFP_KERNEL);
> + /* Usually this means that there is no more space available in
> + * the vq */
The preferred comment style in the networking code is:
/* bla
* bla
*/
[...]
MBR, Sergei
next prev parent reply other threads:[~2016-08-05 16:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 16:34 [PATCH 1/1] VSOCK: remove more space available check filling TX vq ggarcia
2016-08-05 16:53 ` Sergei Shtylyov [this message]
2016-08-10 12:01 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69d05004-506c-dbc2-f97e-b71f4945c703@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=ggarcia@abra.uab.cat \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).