From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v3 23/30] ipv6: defrag: drop non-last frags smaller than
 min mtu
Date: Fri, 11 Jan 2019 02:57:39 -0800
Message-ID: <69e28b74-fe8b-67dc-f290-44c2c0370c85@gmail.com>
References: <20180913145902.17531-1-sthemmin@microsoft.com>
 <20180913145902.17531-24-sthemmin@microsoft.com>
 <CALx6S35t_nFKhjOxRPPHAdsBtjn5P=xhVdL_AuxiFxWTjnSVLA@mail.gmail.com>
 <20190110222231.w7fyfgaepbhuh2fi@breakpoint.cc>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Peter Oskolkov <posk@google.com>,
        Timothy Winters <twinters@iol.unh.edu>
To: Florian Westphal <fw@strlen.de>, Tom Herbert <tom@herbertland.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f66.google.com ([209.85.221.66]:40282 "EHLO
        mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725789AbfAKK5o (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 11 Jan 2019 05:57:44 -0500
Received: by mail-wr1-f66.google.com with SMTP id p4so14697415wrt.7
        for <netdev@vger.kernel.org>; Fri, 11 Jan 2019 02:57:43 -0800 (PST)
In-Reply-To: <20190110222231.w7fyfgaepbhuh2fi@breakpoint.cc>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 01/10/2019 02:22 PM, Florian Westphal wrote:
> Tom Herbert <tom@herbertland.com> wrote:
>> I couldn't find any mention of the advisory in the commit logs or
>> netdev discussion, and apparently there's no protocol requirement that
>> intermediate fragements need to be at least minimal MTU. Maybe this
>> patch should be reverted?
> 
> Currently ipv6 reasm doesn't use rbtree infrastructure, so it would
> have to be converted first.
> 

<quote>
Section 4.5 of RFC 8200 allows for sending any fragment for
fragments as long they add up to the original packet. 
</quote>

I do not believe we need an rbtree to implement this idea.