Re: [PATCH net-next] ionic: Remove unused declarations

Nelson, Shannon
2023-08-21T19:43:00Z

On 8/21/2023 12:39 PM, Jakub Kicinski wrote:
>
> On Mon, 21 Aug 2023 10:26:40 -0700 Nelson, Shannon wrote:
>>> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
>>> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
>>> Commit 969f84394604 ("ionic: sync the filters in the work task")
>>> declared but never implemented ionic_rx_filters_need_sync().
>>>
>>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>>
>> This should include a "Fixes" tag
>
> Nope, it's harmless, no Fixes needed.
> Fixes is for backporting, why would we backport this.

Okay.

Unfortunately I experimented with sending the "changes requested"
message to the pw bot just before receiving your note...

sln