Re: [PATCH net-next] ionic: Remove unused declarations

Jakub Kicinski
2023-08-21T20:05:13Z

On Mon, 21 Aug 2023 12:42:52 -0700 Nelson, Shannon wrote:
> > Nope, it's harmless, no Fixes needed.
> > Fixes is for backporting, why would we backport this.
>
> Okay.
>
> Unfortunately I experimented with sending the "changes requested"
> message to the pw bot just before receiving your note...

As luck would have it - seems like something in the copious Outlook
headers confuses python's email library:

$ wget https://lore.kernel.org/all/69e9c563-2f07-4e9e-b43a-145839fe2afd@amd.com/raw
$ python
>>> import email
>>> from email.policy import default
>>> with open('raw', 'rb') as fp:
... raw = fp.read()
... msg = email.message_from_bytes(raw, policy=default)
...
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[-1]
''
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[0]
'Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net'

It thinks the headers are the body, so we missed the pw-bot command.