From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] net/ncsi: Avoid GFP_KERNEL in response handler Date: Thu, 31 May 2018 04:50:21 -0400 Message-ID: <69fcb143-00a2-2ddf-e2d4-c692b650f292@gmail.com> References: <20180531070254.28878-1-sam@mendozajonas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org To: Samuel Mendoza-Jonas , netdev@vger.kernel.org Return-path: In-Reply-To: <20180531070254.28878-1-sam@mendozajonas.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 05/31/2018 03:02 AM, Samuel Mendoza-Jonas wrote: > ncsi_rsp_handler_gc() allocates the filter arrays using GFP_KERNEL in > softirq context, causing the below backtrace. This allocation is only a > few dozen bytes during probing so allocate with GFP_ATOMIC instead. > Hi Samuel You forgot to add Fixes: 062b3e1b6d4f ("net/ncsi: Refactor MAC, VLAN filters") size = (rsp->uc_cnt + rsp->mc_cnt + rsp->mixed_cnt) * ETH_ALEN; -> seems to be able to reach more than few dozen bytes... Also, what prevents ncsi_rsp_handler_gc() to be called multiples times ? nc->mac_filter.addrs & nc->vlan_filter.vids would be re-allocated and memory would leak.