From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23963C282C0 for ; Fri, 25 Jan 2019 07:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F1F63218DE for ; Fri, 25 Jan 2019 07:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728588AbfAYHym (ORCPT ); Fri, 25 Jan 2019 02:54:42 -0500 Received: from coyote.holtmann.net ([212.227.132.17]:33071 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbfAYHyl (ORCPT ); Fri, 25 Jan 2019 02:54:41 -0500 Received: from marcel-macpro.fritz.box (p4FF9FD60.dip0.t-ipconnect.de [79.249.253.96]) by mail.holtmann.org (Postfix) with ESMTPSA id 7F087CF172; Fri, 25 Jan 2019 09:02:27 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: [PATCH] Bluetooth: make hw_err static, reduces object code size From: Marcel Holtmann In-Reply-To: <20190124172254.13186-1-colin.king@canonical.com> Date: Fri, 25 Jan 2019 08:54:39 +0100 Cc: Johan Hedberg , "David S. Miller" , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: 7bit Message-Id: <6F6742C3-1D20-44F9-9EF6-DF6085069DA0@holtmann.org> References: <20190124172254.13186-1-colin.king@canonical.com> To: Colin King X-Mailer: Apple Mail (2.3445.102.3) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Colin, > Don't populate the const array hw_err on the stack but instead make > it static. Makes the object code smaller by 45 bytes: > > Before: > text data bss dec hex filename > 100880 21090 1088 123058 1e0b2 linux/net/bluetooth/hci_core.o > > After: > text data bss dec hex filename > 100739 21186 1088 123013 1e085 linux/net/bluetooth/hci_core.o > > (gcc version 8.2.0 x86_64) > > Signed-off-by: Colin Ian King > --- > net/bluetooth/hci_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-next tree. Regards Marcel