From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA43BC282CE for ; Fri, 5 Apr 2019 21:16:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 946052173C for ; Fri, 5 Apr 2019 21:16:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B20rdtF0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbfDEVQt (ORCPT ); Fri, 5 Apr 2019 17:16:49 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:40535 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726199AbfDEVQs (ORCPT ); Fri, 5 Apr 2019 17:16:48 -0400 Received: by mail-wm1-f67.google.com with SMTP id z24so8628724wmi.5 for ; Fri, 05 Apr 2019 14:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7IrUPkGfOaV2PEFjva35k++idCxBZpFdQZZBSeKKafU=; b=B20rdtF0Euc1RuLfg5BiOq4HHog4cSI+Y/HeN8vyyhoyMBLWrXUEPOi0YvIRhI1tkM KOTROQestzJZXSgHtP+g81FOwFjgUrmTFvruX7A4YQ3a86SJ7Xx4+AFcliRyakd5II7m SS0UUPog6m/67+Tn1204HUibVO6QBv3KZJyUdtgu9LjOxv/tLjPAbG99loS+vlynAzQ7 AC/8YIy8pEIQiO2Ww+3zHkVaHZyz7hbHJsl87pC61jByo1E/tBNRVfi83Ul5+h0U7ZzL T7fT2KEMX5xZlOtO+2RSB02/hRkRpdB8echd2+JD3RsAo5PUjER5v/IE8benRF6CcXew G4Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7IrUPkGfOaV2PEFjva35k++idCxBZpFdQZZBSeKKafU=; b=EpTUkIBWKsnlgk3MW+jLU0P3tSKtmM8C2Uh+fpxPXdZvJHn8kWhqW36obvVwWsKfbW 4A/KNyK3FfLh5yFDMkwOAWoPhvUGFd04q/g+MgO68Yphstc4hSv5b5qgZrXoFXkTsDME i4m2raBUs/WX6AA8CCVSRt+r9PeocCzYx0+f/NNjxR/6zfclyms5IEGoouYZcSMPYU4t NpkUScyQDES5W2EBhBofD8cnbun71YpSCd2dEOlNi9slXTCiDvfsffcQCGGbYumHkVR8 4Cgzbbs21oS0KQUGjl57JQSEr15mmxIBtDVQ5y33O1BEHtow+j4kEfpiJQSJkd+NayME GxMA== X-Gm-Message-State: APjAAAVBdCRyxkqT2hetgwcgXw1n9ZS8U3ZyXx9y9boDjSw7yAdVAlBN CgwjSiqnpoVcuJDvPX/9aM8auh/q X-Google-Smtp-Source: APXvYqyIj5ZRowRSwOu0AB4slXKa3agbcSC90Z7yA5+o+eM1QP3aP0GPuiAHce1ROphayscNzyAU9g== X-Received: by 2002:a1c:a010:: with SMTP id j16mr9142434wme.40.1554499006743; Fri, 05 Apr 2019 14:16:46 -0700 (PDT) Received: from ?IPv6:2003:ea:8be1:dd00:c5f4:1013:b1cb:d123? (p200300EA8BE1DD00C5F41013B1CBD123.dip0.t-ipconnect.de. [2003:ea:8be1:dd00:c5f4:1013:b1cb:d123]) by smtp.googlemail.com with ESMTPSA id o6sm23916649wrp.41.2019.04.05.14.16.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Apr 2019 14:16:46 -0700 (PDT) Subject: Re: [PATCH net-next] net: phy: improve link partner capability detection To: Florian Fainelli , Andrew Lunn Cc: David Miller , "netdev@vger.kernel.org" References: <20190405194821.GI23536@lunn.ch> <6a86f31f-dda8-77d9-aace-9ad1ad770a28@gmail.com> <20190405202729.GK23536@lunn.ch> <20190405204319.GM23536@lunn.ch> <7e6fc94d-5da9-b87d-a0d3-3e2ee5ff5961@gmail.com> <6cc85416-5ccd-ec90-ede5-11d9cfa298b3@gmail.com> From: Heiner Kallweit Message-ID: <6a052004-e5d4-e63b-4a20-5e7a2381c726@gmail.com> Date: Fri, 5 Apr 2019 23:16:41 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6cc85416-5ccd-ec90-ede5-11d9cfa298b3@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 05.04.2019 23:11, Florian Fainelli wrote: > On 4/5/19 1:51 PM, Heiner Kallweit wrote: >> On 05.04.2019 22:43, Andrew Lunn wrote: >>>> Right. BMSR_ESTATEN should not be set on a Fast PHY. Handling of this >>>> case didn't change. >>>> >>>>> A Fast MAC connected to a Giga PHY. The MAC driver will of used >>>>> phy_set_max_speed() to indicate its limits. In that case, MII_STAT1000 >>>>> does exist and we should report what the peer is advertising. >>>>> >>>> That's what we're doing now with this patch. >>> >>> Hi Heiner >>> >>> What i don't get is why we need to do anything based on the MAC. All >>> we need to do is look at BMSR_ESTATEN, and from that decided if we >>> should look at MII_STAT1000 or not. When reporting what the peer can >>> do, we should not care what the local MAC can do. >>> >> Do we have a misunderstanding? What you describe is exactly what we're >> doing now. BMSR_ESTATEN is read by genphy_read_abilities(). >> I just don't want to read BMSR whenever genphy_read_status() is called. > > You have to read the BMSR to determine the link status anyway, did you > mean: have to check BMSR_ESTATEN whenever genphy_read_status() is called? > I would have to add extra logic to propagate BMSR_ESTATEN from genphy_update_link() to genphy_read_status(). BMSR_ESTATEN has a fixed value and therefore it's sufficient to read it initially.