From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C2C61313524 for ; Thu, 22 Jan 2026 10:27:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769077631; cv=none; b=W8tnNL3pjBpmj/FZIyfCf569Q0eoZc3OJFw9+DahgTBbGmmPOQbu6mwkb0VLRND29B6HL5EHgK7aY4Fo7bG3+8DFRK1X+v1MBO+fg8AzRUDiBtI8rOW+4B02J/0XD0NnV1LjFSYOu6VnqLOlPaS4jSCspWbyikpSVbfCm1Xdv/8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769077631; c=relaxed/simple; bh=tg/IkCOS31JEAFn9hXteDNcfnMrrp5E8OzmuJ6Fv1ek=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A/VmcTksp2RRu6VTu+7DqDEVh+Lp8GPtk5MN7v4KgMJw5lb+Ps/9rOhozs/0PGYSBD+Tkl90SDchmDgvv/xGF9MU/b7L9v17KPgXfq1cWu0eVoCshsC+6DZ2dwI+YSHuOIfKNd3WsJMrF3JxKMyT5DoVt8hzABhvWU8DIUFKPTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HwJ03Hjo; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HwJ03Hjo" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-432d2670932so725477f8f.2 for ; Thu, 22 Jan 2026 02:27:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769077628; x=1769682428; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ls0I+qbyQNmKr9L7fTc+L/4yBpF7MV4e3ITS1qwBIFs=; b=HwJ03Hjo+RmbhWRY1+FoU3ZTzQwtvJFfgJVZlU6XJy5IEd4m9LbRfO0bRQPePuz2E9 +RuDJz65lw5ggL6YXnQRe/AJWpssSo3ajuhVin6IXVXBaA+wxuOXD6+Z4m64Hm39crDG ifJSmqdr08DWL+WSy7+KLaiCEfmZgJJ1wZh2VDfvPh6rCJD4LQSMbYNFojdzGSliR5YG 8nyQkQmXdWqeJ3IDPkOEQ6tN/yut21PXHbyXukWZJgJH3MSomJTjAhX+D3CfgXuAgmim E1acloDGkE7lWDgf4Yfx598T8gI8TTYRLSyQPE/MMRa9N4LrdsdkwcyHh48lF23claom Cz1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769077628; x=1769682428; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ls0I+qbyQNmKr9L7fTc+L/4yBpF7MV4e3ITS1qwBIFs=; b=rhKhcR8msB6FD17xmM4YskgVhVlaC7EiIyP+PSxd4+CV5JeG3CJgE7n3zRmE3qzKoJ 8DMnZ085e9DVVK16oVmc3urQ+VA3eKKR7nTwCGdsDFEBp27HDclDINBPfpDhZTh3rQzT gZprh5Y2qPlflOqs8JBpCcwozmS1KdIMSNb9RSJOZohG1+clXeeOYk5m8a0qMet44hTe x9LtN7utPO8JZHeb29uj8mxrwM0ss9CCT1htQSPb09MeMx8AyGdm/ywu1h3njqa2gVNZ oiYsogd98fj9lyrCfHjwYanHmrQ6K2cNGGU31TxVl9vZsd56bn0f+Je7EGGXPd5l9asi l7nQ== X-Forwarded-Encrypted: i=1; AJvYcCXNJWsw1z44qq87z4tBB8xzW7XCoPo39vzZQ14Bcv26UaQV0dRGNZC6m3XqLVEYlUb5Ca1R9BQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwOIXXsy86KZqxUS6kfxANWdyAjoWoVE78HSw1Bjojmc5B/iSP5 7ehSp8oHPc0zkHLk9fwY6Ggh6QpXwD5WH9au5TiU4RGJNZAUZzM6Yf4M X-Gm-Gg: AZuq6aLUkUdjkiKgOGySUewrRd6IjJVI/lqdIAZem53haiSUQkJ5HUq5Pwu+/cLRXi/ RIIdO1DnKujcuIzhTWi7oWi2Nf1NamnDvYJw6X/TlwkaSso3Q+LJqx8SqBpZgeHJHJNMoW6Wa+j Os3WBK5yThV87diTXDXZtfE+B4ppZErsV9Ncfep12lwilYUUtEikpMIhkaIu0j41hdTURs8e27b g9i54yN+NV9aQfrnfNs9cVkyoTS9unTzavzgx9SjQVl9p8j2vJT8iWLYTJZH534LpjW+7OTG1vk HL7xJZsZU8dARS4Ljobr/a5ok6wiUwv7U5n1EH8h1HOBAgZ86omZvIBtJ03GLoa45zZiWJ+gsPF fHkOIv0p/elQFO3279URwMzEAPXcb1QsoihokYkRX/bCOwdzAgjPmABOriHJF95y/wXmi/COePz yxSZoZe8nnuZXe8lXtKk9jdlUf7AkGuGjIlg== X-Received: by 2002:a05:6000:1888:b0:435:982d:97ee with SMTP id ffacd0b85a97d-435982d99dcmr11152658f8f.57.1769077627762; Thu, 22 Jan 2026 02:27:07 -0800 (PST) Received: from [10.221.200.32] ([165.85.126.46]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4356997eb1fsm43860796f8f.35.2026.01.22.02.27.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Jan 2026 02:27:07 -0800 (PST) Message-ID: <6a055080-e4f1-4a1d-98ba-dca81a26b3a0@gmail.com> Date: Thu, 22 Jan 2026 12:27:08 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] net/mlx5: Fix memory leak in esw_acl_ingress_lgcy_setup() To: Zilin Guan , saeedm@nvidia.com Cc: leon@kernel.org, tariqt@nvidia.com, mbloch@nvidia.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, jianhao.xu@seu.edu.cn References: <20260120134640.2717808-1-zilin@seu.edu.cn> Content-Language: en-US From: Tariq Toukan In-Reply-To: <20260120134640.2717808-1-zilin@seu.edu.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 20/01/2026 15:46, Zilin Guan wrote: > In esw_acl_ingress_lgcy_setup(), if esw_acl_table_create() fails, > the function returns directly without releasing the previously > created counter, leading to a memory leak. > > Fix this by jumping to the out label instead of returning directly, > which aligns with the error handling logic of other paths in this > function. > > Compile tested only. Issue found using a prototype static analysis tool > and code review. > > Fixes: 07bab9502641 ("net/mlx5: E-Switch, Refactor eswitch ingress acl codes") > Signed-off-by: Zilin Guan > --- > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c > index 1c37098e09ea..49a637829c59 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c > @@ -188,7 +188,7 @@ int esw_acl_ingress_lgcy_setup(struct mlx5_eswitch *esw, > if (IS_ERR(vport->ingress.acl)) { > err = PTR_ERR(vport->ingress.acl); > vport->ingress.acl = NULL; > - return err; > + goto out; > } > > err = esw_acl_ingress_lgcy_groups_create(esw, vport); Reviewed-by: Tariq Toukan Thanks for your patch. Tariq