From: David Ahern <dsahern@gmail.com>
To: Patrisious Haddad <phaddad@nvidia.com>,
jgg@ziepe.ca, leon@kernel.org, stephen@networkplumber.org
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com, linux-kernel@vger.kernel.org,
huangjunxian6@hisilicon.com, michaelgur@nvidia.com
Subject: Re: [PATCH v2 iproute2-next 2/3] rdma: Add an option to set privileged QKEY parameter
Date: Tue, 24 Oct 2023 11:02:20 -0600 [thread overview]
Message-ID: <6a1632a4-28fd-4fdd-b9ff-34dd2f0bba88@gmail.com> (raw)
In-Reply-To: <20231023112217.3439-3-phaddad@nvidia.com>
On 10/23/23 5:22 AM, Patrisious Haddad wrote:
> diff --git a/rdma/sys.c b/rdma/sys.c
> index fd785b25..db34cb41 100644
> --- a/rdma/sys.c
> +++ b/rdma/sys.c
> @@ -40,6 +40,17 @@ static int sys_show_parse_cb(const struct nlmsghdr *nlh, void *data)
> mode_str);
> }
>
> + if (tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]) {
> + uint8_t pqkey_mode;
> +
> + pqkey_mode =
> + mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_PRIVILEGED_QKEY_MODE]);
just make it mode so it fits on one line.
40 characters for an attribute name .... I will never understand this
fascination with writing a sentence for an attribute name.
> +
> + print_color_on_off(PRINT_ANY, COLOR_NONE, "privileged-qkey",
> + "privileged-qkey %s ", pqkey_mode);
> +
> + }
> +
> if (tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK])
> cof = mnl_attr_get_u8(tb[RDMA_NLDEV_SYS_ATTR_COPY_ON_FORK]);
>
keep Petr's reviewed-by tag on the respin.
next prev parent reply other threads:[~2023-10-24 17:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 11:22 [PATCH v2 iproute2-next 0/3] Add support to set privileged qkey parameter Patrisious Haddad
2023-10-23 11:22 ` [PATCH v2 iproute2-next 1/3] rdma: update uapi headers Patrisious Haddad
2023-10-23 11:22 ` [PATCH v2 iproute2-next 2/3] rdma: Add an option to set privileged QKEY parameter Patrisious Haddad
2023-10-24 15:34 ` Petr Machata
2023-10-24 17:02 ` David Ahern [this message]
2023-10-25 6:26 ` Patrisious Haddad
2023-10-25 8:34 ` Petr Machata
2023-10-25 8:25 ` Petr Machata
2023-10-23 11:22 ` [PATCH v2 iproute2-next 3/3] rdma: Adjust man page for rdma system set privileged_qkey command Patrisious Haddad
2023-10-24 16:09 ` Petr Machata
2023-10-24 17:04 ` David Ahern
2023-10-25 6:10 ` Patrisious Haddad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a1632a4-28fd-4fdd-b9ff-34dd2f0bba88@gmail.com \
--to=dsahern@gmail.com \
--cc=huangjunxian6@hisilicon.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=michaelgur@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=phaddad@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).