Netdev List
 help / color / mirror / Atom feed
From: Fernando Fernandez Mancera <fmancera@suse.de>
To: Ido Schimmel <idosch@nvidia.com>, Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
	horms@kernel.org, pabeni@redhat.com, edumazet@google.com,
	dsahern@kernel.org, davem@davemloft.net,
	"Łukasz Stelmach" <steelman@post.pl>
Subject: Re: [PATCH 1/2 net v4] ipv6: addrconf: fix temp address generation after prefix deprecation
Date: Wed, 13 May 2026 09:48:51 +0200	[thread overview]
Message-ID: <6a4daea6-928e-43a8-82dd-d669897330e0@suse.de> (raw)
In-Reply-To: <20260513071722.GA334995@shredder>

On 5/13/26 9:17 AM, Ido Schimmel wrote:
> On Tue, May 12, 2026 at 05:01:17PM -0700, Jakub Kicinski wrote:
>> On Mon, 11 May 2026 14:26:45 +0200 Fernando Fernandez Mancera wrote:
>>> When a router temporarily deprecates an IPv6 prefix (either by sending a
>>> Router Advertisement with Preferred Lifetime = 0 or by letting the
>>> lifetime expire) and later restores it, the kernel permanently loses its
>>> ability to generate temporary privacy addresses (RFC 8981) for that
>>> prefix.
>>>
>>> This happens because the address worker attempts to generate a
>>> replacement temporary address when the current one nears expiration. As
>>> the base prefix is deprecated already, the generation fails after
>>> marking the temporary address as already having spawned a replacement
>>> (ifp->regen_count++).
>>>
>>> When the router eventually restores the prefix, the temporary address
>>> becomes active again. However, once it naturally expires, the address
>>> worker sees this temporary address already tried to generate one and
>>> skips the regeneration.
>>>
>>> Fix this by checking if all temporary addresses for a given prefix have
>>> already tried to spawn a replacement when processing a new RA. If so,
>>> spawn a new temporary address.
>>>
>>> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
>>
>> No feedback on the patch itself, but I wanted to check - Ido, do you
>> think this is worth handling as a fix? Sounds like this scenario never
>> worked.
> 
> No, I think we should target net-next. The scenario never worked and the
> fix has the potential to cause other issues.
> 

That is fine for me too.

> Fernando, please wait with the next version. I need some time to go over
> the Sashiko feedback.

Sure thing, no need to rush it.

Thanks Ido!

      reply	other threads:[~2026-05-13  7:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 12:26 [PATCH 1/2 net v4] ipv6: addrconf: fix temp address generation after prefix deprecation Fernando Fernandez Mancera
2026-05-11 12:26 ` [PATCH 2/2 net v4] selftests: fib_tests: add temporary IPv6 address renewal test Fernando Fernandez Mancera
2026-05-11 17:01   ` Breno Leitao
2026-05-12  0:08     ` Jakub Kicinski
2026-05-12  8:08       ` Breno Leitao
2026-05-12 23:56         ` Jakub Kicinski
2026-05-13  8:42           ` Breno Leitao
2026-05-12 18:24 ` [PATCH 1/2 net v4] ipv6: addrconf: fix temp address generation after prefix deprecation Fernando Fernandez Mancera
2026-05-13 14:35   ` Ido Schimmel
2026-05-13  0:01 ` Jakub Kicinski
2026-05-13  7:17   ` Ido Schimmel
2026-05-13  7:48     ` Fernando Fernandez Mancera [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6a4daea6-928e-43a8-82dd-d669897330e0@suse.de \
    --to=fmancera@suse.de \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=idosch@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=steelman@post.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox