From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 152A8C282C2 for ; Wed, 6 Feb 2019 17:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D64A3217F9 for ; Wed, 6 Feb 2019 17:20:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NXBtmIhg" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729545AbfBFRUP (ORCPT ); Wed, 6 Feb 2019 12:20:15 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:42675 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727467AbfBFRUN (ORCPT ); Wed, 6 Feb 2019 12:20:13 -0500 Received: by mail-pg1-f193.google.com with SMTP id d72so3171726pga.9 for ; Wed, 06 Feb 2019 09:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=v4U/1l0kVRnTelvnaxNQ1RxyLDWli691nZIRKKcSz4I=; b=NXBtmIhg0XYi51HiVFftE0VH96Wp+mgyLcCKUIPKasixvXxU+29Y/MeW5UErGz+5Wy XJnCHeIdVQl1UVCitnLXTEMUQOaf3sY4YJQbp5fC4FI7ASuQbpsF6KhS/MjbGk7A8jye ZOZpX3Mwm8WurzE0mLhg3HZym6mso+AaYEXK6nqoR9oMExo4QJthFciIS2tqIcp367aC /Kg2z2jYGTkQ5ZphCL9vNa0uiLCYrYJpsAw5FDgWlqFmDubQibxwSzlN2ep6TSLMBjdF QzhC/GTW3vqkgPrB8BvWAKcGxO8x7cRyH17Xvv8T2mCRDGMW52HUzvOGTt34zVovlheG DCTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=v4U/1l0kVRnTelvnaxNQ1RxyLDWli691nZIRKKcSz4I=; b=tfHk4W0JORzH1Wr08P0nCP6NxASsf1xfATnUS7MzKNGhOmAIZOb5kOV6Rqz5AOxeEt hpI5MovguLPToOzSjQAlcmjUWwVYkdBaX2B7vS7+wzgBthS1FnjI/IU0EMhllEB8ss9m 6I57bP1yuSeVI9X0+RReFpy0ebu19isx32t4bYDnJAn1p7Q7Zbrjwg2xU4eHx4p0a9mD j9mCVnNfd5QFEv8wYWY828fTHBQf1OfEEIEQr6xfQEZH+gXQiIfrUzWUQWqIcunaS4q0 VLCKx3lp0As0e7F97eqgpaJ4TavSd/xMBPSXWnoj9h6WXwK7r3qZSytPujZ6k+iZ/Qsz JaPg== X-Gm-Message-State: AHQUAuavTVT2AQNwTrVT0l8JJXP5RcWBbDlZwwQ/D+BDRiYJQOx7PheD X9zZ2y/f9z53fyKwHDLKkaLHuPpu X-Google-Smtp-Source: AHgI3IaFdi3A5fAY5BljJi9I/EN54AKhz4JwdgNl+MnWVoP2a3dfisLikCQAqgOwW9o9T3w/jI+87g== X-Received: by 2002:a65:41c2:: with SMTP id b2mr5654629pgq.67.1549473612110; Wed, 06 Feb 2019 09:20:12 -0800 (PST) Received: from [10.40.10.126] (fw.cumulusnetworks.com. [216.129.126.126]) by smtp.googlemail.com with ESMTPSA id o189sm10448525pfg.117.2019.02.06.09.20.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 09:20:11 -0800 (PST) Subject: Re: [PATCH iproute2-next v5] devlink: add info subcommand To: Jakub Kicinski , jiri@resnulli.us Cc: stephen@networkplumber.org, netdev@vger.kernel.org, oss-drivers@netronome.com References: <20190204161011.7808-1-jakub.kicinski@netronome.com> From: David Ahern Message-ID: <6a9127ec-e35a-af9d-6091-5d8a9d71b2f4@gmail.com> Date: Wed, 6 Feb 2019 09:20:10 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190204161011.7808-1-jakub.kicinski@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/4/19 8:10 AM, Jakub Kicinski wrote: > Add support for reading the device serial number, driver name > and various versions. Example: > > $ devlink dev info pci/0000:82:00.0 > pci/0000:82:00.0: > driver nfp > serial_number 16240145 > versions: > fixed: > board.id AMDA0081-0001 > board.rev 15 > board.vendor SMA > board.model hydrogen > running: > fw.mgmt 010181.010181.0101d4 > fw.cpld 0x1030000 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > stored: > fw.mgmt 010181.010181.0101d4 > fw.app abm-d372b6 > fw.undi 0.0.2 > chip.init AMDA-0081-0001 20160318164536 > > $ devlink -jp dev info pci/0000:82:00.0 > { > "info": { > "pci/0000:82:00.0": { > "driver": "nfp", > "serial_number": "16240145", > "versions": { > "fixed": { > "board.id": "AMDA0081-0001", > "board.rev": "15", > "board.vendor": "SMA", > "board.model": "hydrogen" > }, > "running": { > "fw.mgmt": "010181.010181.0101d4", > "fw.cpld": "0x1030000", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > }, > "stored": { > "fw.mgmt": "010181.010181.0101d4", > "fw.app": "abm-d372b6", > "fw.undi": "0.0.2", > "chip.init": "AMDA-0081-0001 20160318164536" > } > } > } > } > } > > v5: > - remove spurious new line. > v4: > - more commit message improvements. > v3: > - show up-to-date output in the commit message. > v2 (Jiri): > - remove filtering; > - add example in the commit message. > RFCv2: > - make info subcommand of dev. > > Signed-off-by: Jakub Kicinski > --- > devlink/devlink.c | 171 +++++++++++++++++++++++++++++++++++++++++ > man/man8/devlink-dev.8 | 26 +++++++ > 2 files changed, 197 insertions(+) > applied to iproute2-next. Thanks for adding the example output