From mboxrd@z Thu Jan  1 00:00:00 1970
From: Quentin Monnet <quentin.monnet@netronome.com>
Subject: Re: [PATCH net-next V3 0/3] tools: bpftool: show filenames of pinned
 objects
Date: Mon, 6 Nov 2017 10:45:39 +0000
Message-ID: <6ad52dec-31f7-37e2-5110-c5e07a4024c2@netronome.com>
References: <20171106060632.3380-1-bhole_prashant_q7@lab.ntt.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Jakub Kicinski <jakub.kicinski@netronome.com>
To: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>,
        "David S . Miller" <davem@davemloft.net>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wm0-f42.google.com ([74.125.82.42]:51258 "EHLO
        mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751490AbdKFKpn (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 6 Nov 2017 05:45:43 -0500
Received: by mail-wm0-f42.google.com with SMTP id b9so13232297wmh.0
        for <netdev@vger.kernel.org>; Mon, 06 Nov 2017 02:45:42 -0800 (PST)
In-Reply-To: <20171106060632.3380-1-bhole_prashant_q7@lab.ntt.co.jp>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

2017-11-06 15:06 UTC+0900 ~ Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
> This patchset adds support to show pinned objects in object details.
> 
> Patch1 adds a funtionality to open a path in bpf-fs regardless of its object
> type.
> 
> Patch2 adds actual functionality by scanning the bpf-fs once and adding
> object information in hash table, with object id as a key. One object may be
> associated with multiple paths because an object can be pinned multiple times
> 
> Patch3 adds command line option to enable this functionality. Making it optional
> because scanning bpf-fs can be costly.
> 
> v1->v2:
>  - Dynamically identify bpf-fs moutpoint
>  - Close files descriptors before returning on error
>  - Change command line option from {-l|--pinned} to {-f|--bpffs}
>  - Updated documentation
>  - Fixed line break for proper output formatting
>  - Code style: wrapped lines > 80, used reverse christmastree style
> 
> v2->v3:
>  - Handle multiple bpffs mountpoints
>  - Code style: fixed line break indentation
> 

Thanks for the changes! This version looks good to me.

Acked-by: Quentin Monnet <quentin.monnet@netronome.com>