From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net] net: phy: micrel: set soft_reset callback to genphy_soft_reset for KSZ9031 Date: Thu, 10 Jan 2019 11:24:57 -0800 Message-ID: <6ad9a9c8-3f65-b16e-19d1-b54efb3a0b70@gmail.com> References: <6d3b1dce-7633-51a1-0556-97cd03304c2c@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , Tony Lindgren To: Heiner Kallweit , Andrew Lunn , David Miller Return-path: Received: from mail-yb1-f195.google.com ([209.85.219.195]:45003 "EHLO mail-yb1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728572AbfAJTZH (ORCPT ); Thu, 10 Jan 2019 14:25:07 -0500 Received: by mail-yb1-f195.google.com with SMTP id e1so4871140ybn.11 for ; Thu, 10 Jan 2019 11:25:05 -0800 (PST) In-Reply-To: <6d3b1dce-7633-51a1-0556-97cd03304c2c@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 1/10/19 11:22 AM, Heiner Kallweit wrote: > So far genphy_soft_reset was used automatically if the PHY driver > didn't implement the soft_reset callback. This changed with the > mentioned commit and broke KSZ9031. To fix this configure the > KSZ9031 PHY driver to use genphy_soft_reset. > > Fixes: 6e2d85ec0559 ("net: phy: Stop with excessive soft reset") > Reported-by: Tony Lindgren > Signed-off-by: Heiner Kallweit Thanks a lot for following up with the people at TI on this. We should really get a better understanding of what the issue is, and whether there is a possibly better workaround that could be developed which is not just as hard as a big hammer software reset. Maybe we can get some people/contacts at Micrel to help here. > --- > drivers/net/phy/micrel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c > index c33384710..7828d17f0 100644 > --- a/drivers/net/phy/micrel.c > +++ b/drivers/net/phy/micrel.c > @@ -1070,6 +1070,7 @@ static struct phy_driver ksphy_driver[] = { > .driver_data = &ksz9021_type, > .probe = kszphy_probe, > .config_init = ksz9031_config_init, > + .soft_reset = genphy_soft_reset, > .read_status = ksz9031_read_status, > .ack_interrupt = kszphy_ack_interrupt, > .config_intr = kszphy_config_intr, > -- Florian