From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Peter Rosin <peda@axentia.se>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Kalle Valo <kvalo@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Sebastian Reichel <sre@kernel.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
Maxime Ripard <mripard@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org,
linux-input@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-serial@vger.kernel.org, alsa-devel@alsa-project.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: Fix properties without any type
Date: Sat, 21 May 2022 17:03:41 +0200 [thread overview]
Message-ID: <6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org> (raw)
In-Reply-To: <20220519211411.2200720-1-robh@kernel.org>
On 19/05/2022 23:14, Rob Herring wrote:
> Now that the schema tools can extract type information for all
> properties (in order to decode dtb files), finding properties missing
> any type definition is fairly trivial though not yet automated.
>
> Fix the various property schemas which are missing a type. Most of these
> tend to be device specific properties which don't have a vendor prefix.
> A vendor prefix is how we normally ensure a type is defined.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> .../arm/hisilicon/controller/hip04-bootwrapper.yaml | 5 +++--
> .../bindings/display/bridge/toshiba,tc358768.yaml | 1 +
> .../devicetree/bindings/display/panel/panel-timing.yaml | 5 +++++
> .../bindings/display/panel/raydium,rm67191.yaml | 1 +
> .../bindings/display/panel/samsung,s6e8aa0.yaml | 1 +
> .../devicetree/bindings/gpio/fairchild,74hc595.yaml | 1 +
> .../devicetree/bindings/input/google,cros-ec-keyb.yaml | 1 +
> .../devicetree/bindings/input/matrix-keymap.yaml | 4 ++++
> Documentation/devicetree/bindings/media/i2c/adv7604.yaml | 3 ++-
> Documentation/devicetree/bindings/mux/reg-mux.yaml | 8 ++++++--
> Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
> Documentation/devicetree/bindings/net/ingenic,mac.yaml | 1 +
> .../devicetree/bindings/net/ti,davinci-mdio.yaml | 1 +
> .../devicetree/bindings/net/wireless/ti,wlcore.yaml | 2 ++
> .../devicetree/bindings/pci/snps,dw-pcie-ep.yaml | 6 ++++--
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++
> .../devicetree/bindings/pinctrl/canaan,k210-fpioa.yaml | 2 ++
> Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml | 1 +
> .../devicetree/bindings/power/supply/battery.yaml | 7 ++++++-
> .../devicetree/bindings/power/supply/charger-manager.yaml | 1 +
> Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 1 +
> Documentation/devicetree/bindings/serial/8250.yaml | 1 +
> .../devicetree/bindings/sound/audio-graph-card2.yaml | 3 +++
> .../devicetree/bindings/sound/imx-audio-hdmi.yaml | 3 +++
> Documentation/devicetree/bindings/usb/smsc,usb3503.yaml | 1 +
> 25 files changed, 55 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> index 7378159e61df..483caf0ce25b 100644
> --- a/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> +++ b/Documentation/devicetree/bindings/arm/hisilicon/controller/hip04-bootwrapper.yaml
> @@ -17,14 +17,15 @@ properties:
> - const: hisilicon,hip04-bootwrapper
>
> boot-method:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> description: |
> Address and size of boot method.
> [0]: bootwrapper physical address
> [1]: bootwrapper size
> [2]: relocation physical address
> [3]: relocation size
> - minItems: 1
> - maxItems: 2
> + minItems: 2
> + maxItems: 4
>
> required:
> - compatible
> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> index 3bd670b8e5cd..0b6f5bef120f 100644
> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml
> @@ -58,6 +58,7 @@ properties:
>
> properties:
> data-lines:
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [ 16, 18, 24 ]
>
> port@1:
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> index 7749de95ee40..229e3b36ee29 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-timing.yaml
> @@ -146,6 +146,7 @@ properties:
> Horizontal sync pulse.
> 0 selects active low, 1 selects active high.
> If omitted then it is not used by the hardware
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> vsync-active:
> @@ -153,6 +154,7 @@ properties:
> Vertical sync pulse.
> 0 selects active low, 1 selects active high.
> If omitted then it is not used by the hardware
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> de-active:
> @@ -160,6 +162,7 @@ properties:
> Data enable.
> 0 selects active low, 1 selects active high.
> If omitted then it is not used by the hardware
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> pixelclk-active:
> @@ -169,6 +172,7 @@ properties:
> sample data on rising edge.
> Use 1 to drive pixel data on rising edge and
> sample data on falling edge
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> syncclk-active:
> @@ -179,6 +183,7 @@ properties:
> sample sync on rising edge of pixel clock.
> Use 1 to drive sync on rising edge and
> sample sync on falling edge of pixel clock
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [0, 1]
>
> interlaced:
> diff --git a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> index 745dd247c409..617aa8c8c03a 100644
> --- a/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/raydium,rm67191.yaml
> @@ -24,6 +24,7 @@ properties:
>
> dsi-lanes:
> description: Number of DSI lanes to be used must be <3> or <4>
> + $ref: /schemas/types.yaml#/definitions/uint32
> enum: [3, 4]
>
> v3p3-supply:
> diff --git a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> index ca959451557e..1cdc91b3439f 100644
> --- a/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/samsung,s6e8aa0.yaml
> @@ -36,6 +36,7 @@ properties:
>
> init-delay:
> description: delay after initialization sequence [ms]
> + $ref: /schemas/types.yaml#/definitions/uint32
>
> panel-width-mm:
> description: physical panel width [mm]
> diff --git a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> index 5fe19fa5f67c..a99e7842ca17 100644
> --- a/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> +++ b/Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml
> @@ -26,6 +26,7 @@ properties:
> const: 2
>
> registers-number:
> + $ref: /schemas/types.yaml#/definitions/uint32
> description: Number of daisy-chained shift registers
>
> enable-gpios:
> diff --git a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> index e8f137abb03c..aa61fe64be63 100644
> --- a/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> +++ b/Documentation/devicetree/bindings/input/google,cros-ec-keyb.yaml
> @@ -31,6 +31,7 @@ properties:
> type: boolean
>
> function-row-physmap:
> + $ref: /schemas/types.yaml#/definitions/uint32-array
> minItems: 1
> maxItems: 15
> description: |
> diff --git a/Documentation/devicetree/bindings/input/matrix-keymap.yaml b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> index 6699d5e32dca..9f703bb51e12 100644
> --- a/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> +++ b/Documentation/devicetree/bindings/input/matrix-keymap.yaml
> @@ -27,6 +27,10 @@ properties:
> column and linux key-code. The 32-bit big endian cell is packed as:
> row << 24 | column << 16 | key-code
>
> + linux,no-autorepeat:
> + type: boolean
> + description: Disable keyrepeat
This should be rather a separate patch - it's documenting a missing
property, not only a type.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-21 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 21:14 [PATCH] dt-bindings: Fix properties without any type Rob Herring
2022-05-19 21:19 ` Mark Brown
2022-05-20 7:00 ` Peter Rosin
2022-05-20 11:31 ` Bartosz Golaszewski
2022-05-20 15:30 ` Sam Ravnborg
2022-05-21 15:03 ` Krzysztof Kozlowski [this message]
2022-05-23 16:56 ` Rob Herring
2022-05-23 6:59 ` Sebastian Reichel
2022-06-06 3:33 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae55a29-0b29-f53c-c9bd-fae929f3caf7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bhelgaas@google.com \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=herbert@gondor.apana.org.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mpm@selenic.com \
--cc=mripard@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=sre@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).