From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-ve1eur01on0064.outbound.protection.outlook.com ([104.47.1.64]:8928
        "EHLO EUR01-VE1-obe.outbound.protection.outlook.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751673AbeCVQhD (ORCPT <rfc822;netdev@vger.kernel.org>);
        Thu, 22 Mar 2018 12:37:03 -0400
Subject: Re: [bpf-next V4 PATCH 01/15] mlx5: basic XDP_REDIRECT forward
 support
To: Jesper Dangaard Brouer <brouer@redhat.com>, netdev@vger.kernel.org,
        =?UTF-8?B?QmrDtnJuVMO2cGVs?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com
Cc: eugenia@mellanox.com, Jason Wang <jasowang@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
References: <152172842149.20979.12110131083451936498.stgit@firesoul>
 <152172847318.20979.18419058830882883814.stgit@firesoul>
From: Tariq Toukan <tariqt@mellanox.com>
Message-ID: <6b1a826f-cbb8-c4a5-5d12-4e7e3b9d20de@mellanox.com>
Date: Thu, 22 Mar 2018 18:36:54 +0200
MIME-Version: 1.0
In-Reply-To: <152172847318.20979.18419058830882883814.stgit@firesoul>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 22/03/2018 4:21 PM, Jesper Dangaard Brouer wrote:
> This implements basic XDP redirect support in mlx5 driver.
> 
> Notice that the ndo_xdp_xmit() is NOT implemented, because that API
> need some changes that this patchset is working towards.
> 
> The main purpose of this patch is have different drivers doing
> XDP_REDIRECT to show how different memory models behave in a cross
> driver world.
> 
> Update(pre-RFCv2 Tariq): Need to DMA unmap page before xdp_do_redirect,
> as the return API does not exist yet to to keep this mapped.
> 
> Update(pre-RFCv3 Saeed): Don't mix XDP_TX and XDP_REDIRECT flushing,
> introduce xdpsq.db.redirect_flush boolian.
> 
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/en.h    |    1 +
>   drivers/net/ethernet/mellanox/mlx5/core/en_rx.c |   27 ++++++++++++++++++++---
>   2 files changed, 25 insertions(+), 3 deletions(-)
> 

Reviewed-by: Tariq Toukan <tariqt@mellanox.com>