From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net-next v4 4/9] net: provide a sysctl raw_l3mdev_accept
 for raw socket lookup with VRFs
Date: Tue, 6 Nov 2018 11:05:59 -0700
Message-ID: <6b44b80b-8624-0ea2-5076-3318a0621cae@gmail.com>
References: <20181102191020.14170-1-mmanning@vyatta.att-mail.com>
 <20181102191020.14170-5-mmanning@vyatta.att-mail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Mike Manning <mmanning@vyatta.att-mail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f195.google.com ([209.85.210.195]:40979 "EHLO
        mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1730164AbeKGDc1 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 6 Nov 2018 22:32:27 -0500
Received: by mail-pf1-f195.google.com with SMTP id e22-v6so6460212pfn.8
        for <netdev@vger.kernel.org>; Tue, 06 Nov 2018 10:06:02 -0800 (PST)
In-Reply-To: <20181102191020.14170-5-mmanning@vyatta.att-mail.com>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On 11/2/18 1:10 PM, Mike Manning wrote:
> diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
> index 8ca3eb06ba04..da453c7dfb75 100644
> --- a/net/ipv4/raw.c
> +++ b/net/ipv4/raw.c
> @@ -805,7 +805,7 @@ static int raw_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
>  	return copied;
>  }
>  
> -static int raw_init(struct sock *sk)
> +static int raw_sk_init(struct sock *sk)
>  {
>  	struct raw_sock *rp = raw_sk(sk);
>  
> @@ -970,7 +970,7 @@ struct proto raw_prot = {
>  	.connect	   = ip4_datagram_connect,
>  	.disconnect	   = __udp_disconnect,
>  	.ioctl		   = raw_ioctl,
> -	.init		   = raw_init,
> +	.init		   = raw_sk_init,
>  	.setsockopt	   = raw_setsockopt,
>  	.getsockopt	   = raw_getsockopt,
>  	.sendmsg	   = raw_sendmsg,
> @@ -1133,4 +1133,16 @@ void __init raw_proc_exit(void)
>  {
>  	unregister_pernet_subsys(&raw_net_ops);
>  }
> +
> +static void raw_sysctl_init(void)
> +{
> +#ifdef CONFIG_NET_L3_MASTER_DEV
> +	init_net.ipv4.sysctl_raw_l3mdev_accept = 1;
> +#endif

That is not propagated to new network namespaces:

# ip netns add ns1
# ip netns exec ns1 sysctl -a 2>/dev/null | grep l3mdev
net.ipv4.raw_l3mdev_accept = 0


> +}
> +
> +void __init raw_init(void)
> +{
> +	raw_sysctl_init();
> +}
>  #endif /* CONFIG_PROC_FS */