Re: [PATCH net-next 5/8] net/sched: add const qualifiers to gnet_stats helpers

[Victor Nogueira <victor@mojatatu.com>]

On 07/05/2026 19:19, Eric Dumazet wrote:
> In preparation of lockless qdisc dumps, add const qualifiers to:
> 
> - gnet_stats_add_basic()
> - gnet_stats_copy_basic()
> - gnet_stats_copy_queue()
> - gnet_stats_read_basic()
> - ___gnet_stats_copy_basic()
> 
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> [...]
> diff --git a/net/core/gen_stats.c b/net/core/gen_stats.c
> index 1a2380e74272de8eaf3d4ef453e56105a31e9edf..3b2f9ea2eb072dde792aad5b60cf00dcc2efa76d 100644
> --- a/net/core/gen_stats.c
> +++ b/net/core/gen_stats.c
> @@ -124,7 +124,7 @@ void gnet_stats_basic_sync_init(struct gnet_stats_basic_sync *b)
>   EXPORT_SYMBOL(gnet_stats_basic_sync_init);
>   
>   static void gnet_stats_add_basic_cpu(struct gnet_stats_basic_sync *bstats,
> -				     struct gnet_stats_basic_sync __percpu *cpu)
> +				     const struct gnet_stats_basic_sync __percpu *cpu)

This seems to be causing a compilation error:

net/core/gen_stats.c: In function ‘gnet_stats_add_basic_cpu’:
./include/linux/percpu-defs.h:238:1: error: initialization discards 
‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers]
   238 | ({ 
         \
       | ^
net/core/gen_stats.c:133:54: note: in expansion of macro ‘per_cpu_ptr’
   133 |                 struct gnet_stats_basic_sync *bcpu = 
per_cpu_ptr(cpu, i);

cheers,
Victor