Netdev List
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
To: Tomas Paukrt <Tomas.Paukrt@advantech-bb.cz>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "roopa@cumulusnetworks.com" <roopa@cumulusnetworks.com>
Subject: Re: Bug in br_handle_frame
Date: Fri, 15 Feb 2019 16:12:18 +0200	[thread overview]
Message-ID: <6b5d5550-07b3-61d7-c3ad-ec31f17fa862@cumulusnetworks.com> (raw)
In-Reply-To: <2c692688-ea77-1e80-6607-6577b157873a@advantech-bb.cz>

On 15/02/2019 16:03, Tomas Paukrt wrote:
> Hi,
> 
> I have recently discovered that kernel 3.12.10 is occasionally crashing 
> due to NULL pointer dereference in function br_handle_frame when we 
> reconfigure the bridge, because function br_port_get_rcu returns NULL.
> 
> It is very hard for us to replicate this issue, because it happens about 
> once per month in our testing environment, but I have created the 
> attached patch. Can you please check it? The latest kernel seems to be 
> affected too.
> 
> Best regards
> 
> Tomas
> 

Hi,
That should not be possible, br_port_get_rcu() is a wrapper for
dev->rx_handler_data which in turn should always be present in case
rx_handler is called as can be seen in netdev_rx_handler_unregister().
Could you please share details about the crash and possibly a trace ?
Do you have any custom patches applied ?

Thanks,
 Nik


  reply	other threads:[~2019-02-15 14:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 14:03 Bug in br_handle_frame Tomas Paukrt
2019-02-15 14:12 ` Nikolay Aleksandrov [this message]
     [not found]   ` <f8bed7e5-0e3a-095f-4f0f-864d71695445@advantech-bb.cz>
2019-02-15 14:31     ` Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b5d5550-07b3-61d7-c3ad-ec31f17fa862@cumulusnetworks.com \
    --to=nikolay@cumulusnetworks.com \
    --cc=Tomas.Paukrt@advantech-bb.cz \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox