From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com ([209.85.215.68]:44240 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752737AbeBVH5X (ORCPT ); Thu, 22 Feb 2018 02:57:23 -0500 Received: by mail-lf0-f68.google.com with SMTP id v9so6074453lfa.11 for ; Wed, 21 Feb 2018 23:57:23 -0800 (PST) Subject: Re: [PATCH net v2 1/2] Revert "tuntap: add missing xdp flush" To: Jason Wang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: mst@redhat.com, christoffer.dall@linaro.org References: <1519280658-4918-1-git-send-email-jasowang@redhat.com> From: Sergei Shtylyov Message-ID: <6b629082-c8cf-b53a-9ea3-b9da382f65c9@cogentembedded.com> Date: Thu, 22 Feb 2018 10:57:21 +0300 MIME-Version: 1.0 In-Reply-To: <1519280658-4918-1-git-send-email-jasowang@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/22/2018 9:24 AM, Jason Wang wrote: > This reverts commit 762c330d670e3d4b795cf7a8d761866fdd1eef49. The > reason is we try to batch packets for devmap which causes calling > xdp_do_flush() under the process context. Simply disable premmption s/under/in/. Disabling preemption. > may not work since process may move among processors which lead > xdp_do_flush() to miss some flushes on some processors. > > So simply revert the patch, a follow-up path will add the xdp flush > correctly. > > Reported-by: Christoffer Dall > Fixes: 762c330d670e ("tuntap: add missing xdp flush") > Signed-off-by: Jason Wang [...] MBR, Sergei