From: Eric Dumazet <eric.dumazet@gmail.com>
To: Wang Jian <jianjian.wang1@gmail.com>, netdev@vger.kernel.org
Subject: Re: One question about __tcp_select_window()
Date: Tue, 17 Apr 2018 07:43:48 -0700 [thread overview]
Message-ID: <6b7c1a82-e253-09bd-fd3e-363ce6a84653@gmail.com> (raw)
In-Reply-To: <CAP4sYWWzQaq3zKiSXsPgfcL0xXi7Vt+YPwcbq95xqJ+_JE5meA@mail.gmail.com>
On 04/17/2018 06:53 AM, Wang Jian wrote:
> I test the fix with 4.17.0-rc1+ and it seems work.
>
> 1. iperf -c IP -i 20 -t 60 -w 1K
> with-fix vs without-fix : 1.15Gbits/sec vs 1.05Gbits/sec
> I also try other windows and have similar results.
>
> 2. Use tcp probe trace snd_wind.
> with-fix vs without-fix: 1245568 vs 1042816
>
> 3. I don't see extra retransmit/drops.
>
Unfortunately I have no idea what exact problem you had to solve.
Setting small windows is not exactly the path we are taking.
And I do not know how many side effects your change will have for 'standard' flows
using autotuning or sane windows.
next prev parent reply other threads:[~2018-04-17 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-15 12:50 One question about __tcp_select_window() Wang Jian
2018-04-17 13:53 ` Wang Jian
2018-04-17 14:43 ` Eric Dumazet [this message]
2018-04-18 0:23 ` Wang Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7c1a82-e253-09bd-fd3e-363ce6a84653@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=jianjian.wang1@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).