From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ve1eur01on0105.outbound.protection.outlook.com ([104.47.1.105]:26834 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751677AbeCQVzN (ORCPT ); Sat, 17 Mar 2018 17:55:13 -0400 Subject: Re: [rds-devel] [PATCH RFC RFC] rds: Use NETDEV_UNREGISTER in rds_tcp_dev_event() (then kill NETDEV_UNREGISTER_FINAL) To: Sowmini Varadhan Cc: rds-devel@oss.oracle.com, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, edumazet@google.com, davem@davemloft.net References: <152120385651.2065.2567466917573907029.stgit@localhost.localdomain> <20180316130008.GE16870@oracle.com> <512c2483-aa62-b385-6079-1b6ff8ba4636@virtuozzo.com> <20180316172918.GM16870@oracle.com> <82d6e954-8043-078c-266c-2f1ac992f864@virtuozzo.com> <20180317141507.GC873@oracle.com> <20180317212553.GA16416@oracle.com> From: Kirill Tkhai Message-ID: <6b8e60bf-9ea2-ed1c-19ad-809a805f64a3@virtuozzo.com> Date: Sun, 18 Mar 2018 00:55:07 +0300 MIME-Version: 1.0 In-Reply-To: <20180317212553.GA16416@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 18.03.2018 00:26, Sowmini Varadhan wrote: > On (03/17/18 10:15), Sowmini Varadhan wrote: >> To solve the scaling problem why not just have a well-defined >> callback to modules when devices are quiesced, instead of >> overloading the pernet_device registration in this obscure way? > > I thought about this a bit, and maybe I missed your original point- > today we are able to do all the needed cleanup for rds-tcp when > we unload the module, even though network activity has not quiesced, > and there is no reason we cannot use the same code for netns cleanup > as well. I think this is what you were trying to ask, when you > said "why do you need to know that loopback is down?" I just want to make rds not using NETDEV_UNREGISTER_FINAL. If there is another solution to do that, I'm not again that. > I'm sorry I missed that, I will re-examine the code and get back to > you- it should be possible to just do one registration and > cleanup rds-state and avoid the hack of registering twice Sounds great, I'll wait for your response. > (saw your most recent long mail- sorry- both v1 and v2 are hacks) > > I'm on the road at the moment, so I'll get back to you on this. Thanks, Kirill