From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Martin Faltesek <mfaltesek@chromium.org>,
netdev@vger.kernel.org, kuba@kernel.org,
christophe.ricard@gmail.com, jordy@pwning.systems
Cc: sameo@linux.intel.com, wklin@google.com, groeck@google.com,
mfaltesek@google.com, gregkh@linuxfoundation.org
Subject: Re: [PATCH v2 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling
Date: Sat, 2 Apr 2022 11:01:45 +0200 [thread overview]
Message-ID: <6bb1d5bf-7ee1-c559-aafc-98664b9519dc@linaro.org> (raw)
In-Reply-To: <20220401181032.2026076-1-mfaltesek@google.com>
On 01/04/2022 20:10, Martin Faltesek wrote:
> Error paths do not free previously allocated memory. Add devm_kfree() to
> those failure paths.
>
> Fixes: 26fc6c7f02cb ("NFC: st21nfca: Add HCI transaction event support")
> Fixes: 4fbcc1a4cb20 ("nfc: st21nfca: Fix potential buffer overflows in EVT_TRANSACTION")
> Signed-off-by: Martin Faltesek <mfaltesek@google.com>
> ---
> drivers/nfc/st21nfca/se.c | 13 ++++++++++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2022-04-02 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 18:10 [PATCH v2 2/3] nfc: st21nfca: fix memory leaks in EVT_TRANSACTION handling Martin Faltesek
2022-04-02 9:01 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bb1d5bf-7ee1-c559-aafc-98664b9519dc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=christophe.ricard@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@google.com \
--cc=jordy@pwning.systems \
--cc=kuba@kernel.org \
--cc=mfaltesek@chromium.org \
--cc=mfaltesek@google.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=wklin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).