From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, nfont@linux.vnet.ibm.com,
jallen@linux.vnet.ibm.com
Subject: Re: [PATCH net] ibmvnic: Clean RX pools only during a hard reset
Date: Mon, 19 Feb 2018 14:01:00 -0600 [thread overview]
Message-ID: <6bc62728-e3b0-a9ef-242b-abf3e9d1cc90@linux.vnet.ibm.com> (raw)
In-Reply-To: <20180219.143057.1751495030105842591.davem@davemloft.net>
On 02/19/2018 01:30 PM, David Miller wrote:
> From: Thomas Falcon <tlfalcon@linux.vnet.ibm.com>
> Date: Mon, 19 Feb 2018 13:24:52 -0600
>
>> Sorry, I should explain it better. It's not there is a double free.
>> It's that the driver is receiving RX descriptors from the previous
>> session for which socket buffers have been freed. The driver's
>> polling routine tries to copy data to the socket buffer, but it's
>> been freed, so it's trying to copy to a NULL pointer.
> That's kinda hairy, is this resend of the old descriptors guaranteed
> to always happen in this situation?
>
> Maybe it's better to have some way for the RX descriptor receiving
> path to detect this situation (is SKB slot NULL?) to handle the
> problem there.
It is something we can expect to happen in this situation. Thanks for the suggestion. That way the driver can free up that memory when it closes. I'll try to get a v2 out soon.
Thanks again.
> Thanks.
>
next prev parent reply other threads:[~2018-02-19 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-18 16:08 [PATCH net] ibmvnic: Clean RX pools only during a hard reset Thomas Falcon
2018-02-18 16:08 ` [PATCH net-next] ibmvnic: Keep track of supplementary TX descriptors Thomas Falcon
2018-02-20 18:20 ` David Miller
2018-02-19 16:37 ` [PATCH net] ibmvnic: Clean RX pools only during a hard reset David Miller
2018-02-19 19:24 ` Thomas Falcon
2018-02-19 19:30 ` David Miller
2018-02-19 20:01 ` Thomas Falcon [this message]
2018-02-20 2:12 ` [PATCH net v2] ibmvnic: Check for NULL skb's in NAPI poll routine Thomas Falcon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc62728-e3b0-a9ef-242b-abf3e9d1cc90@linux.vnet.ibm.com \
--to=tlfalcon@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=jallen@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).