From: Chris Mason <clm@meta.com>
To: Jakub Sitnicki <jakub@cloudflare.com>, bot+bpf-ci@kernel.org
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
kernel-team@cloudflare.com, martin.lau@linux.dev, ast@kernel.org,
andrii@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org,
eddyz87@gmail.com, yonghong.song@linux.dev,
ihor.solodrai@linux.dev
Subject: Re: [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC progs using data_meta
Date: Tue, 25 Nov 2025 09:52:00 -0500 [thread overview]
Message-ID: <6bd2a44a-0e79-497b-8add-2db8bff81f28@meta.com> (raw)
In-Reply-To: <87cy565gxw.fsf@cloudflare.com>
On 11/25/25 9:23 AM, Jakub Sitnicki wrote:
> On Mon, Nov 24, 2025 at 04:58 PM GMT, bot+bpf-ci@kernel.org wrote:
>> This appears to fix the bug introduced by commit 016079023cef ("net:
>> Track skb metadata end separately from MAC offset"). Should this include
>> a Fixes: tag?
>>
>> The earlier commit message explicitly noted: "Note that this breaks BPF
>> skb metadata access through skb->data_meta when there is a gap between
>> meta_end and skb->data. Following BPF verifier changes address this."
>>
>> This commit is one of those follow-up changes that addresses the
>> breakage.
>
> False-positive feedback, naturally. Both breaking change and the fix
> belong to the same patch series, so Fixes tagging rules don't apply.
Thanks, I disabled the Fixes: tag checks until I can beef them up a bit.
Sounds like I need to get the patch series aware reviews working first.
-chris
prev parent reply other threads:[~2025-11-25 14:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 16:28 [PATCH RFC bpf-next 00/15] Decouple skb metadata tracking from MAC header offset Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 01/15] bnxt_en: Call skb_metadata_set when skb->data points at metadata end Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 02/15] i40e: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 03/15] igb: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 04/15] igc: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 05/15] ixgbe: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 06/15] net/mlx5e: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 07/15] veth: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 08/15] xsk: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 09/15] xdp: " Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 10/15] net: Track skb metadata end separately from MAC offset Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 11/15] bpf, verifier: Remove side effects from may_access_direct_pkt_data Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 12/15] bpf, verifier: Turn seen_direct_write flag into a bitmap Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 13/15] bpf, verifier: Propagate packet access flags to gen_prologue Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 14/15] bpf, verifier: Track when data_meta pointer is loaded Jakub Sitnicki
2025-11-24 16:28 ` [PATCH RFC bpf-next 15/15] bpf: Realign skb metadata for TC progs using data_meta Jakub Sitnicki
2025-11-24 16:58 ` bot+bpf-ci
2025-11-25 14:23 ` Jakub Sitnicki
2025-11-25 14:52 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bd2a44a-0e79-497b-8add-2db8bff81f28@meta.com \
--to=clm@meta.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).