netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Chia-chi Yeh (葉家齊)" <chiachi@android.com>
To: Badalian Vyacheslav <slavon@bigtelecom.ru>
Cc: David Miller <davem@davemloft.net>,
	john.dykstra1@gmail.com, akpm@linux-foundation.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0
Date: Tue, 4 Aug 2009 16:28:34 +0800	[thread overview]
Message-ID: <6c039e090908040128l7bdaf45j3305e5e392562b85@mail.gmail.com> (raw)
In-Reply-To: <4A77E9FA.7030503@bigtelecom.ru>

On Tue, Aug 4, 2009 at 3:57 PM, Badalian Vyacheslav<slavon@bigtelecom.ru> wrote:
>
> Hello
> Sorry if its my mistake or i someone not understand :)
>
> if (ipc->oif && info->ipi_ifindex != ipc->oif)
>        // if match: info->ipi_ifindex != ipc->oif
>        return ...
> else
>        // else match: info->ipi_ifindex == ipc->oif
>        // but you do
>        ipc->oif = info->ipi_ifindex;
>        // why if you else match allready check for it?
>
> Thanks

Hi Badalian,

Consider ipc->oif = 0 before the if-condition. :)

Chia-chi

  reply	other threads:[~2009-08-04  8:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <6c039e090907231439t1def08a4n10978733bee55bec@mail.gmail.com>
2009-07-27 21:44 ` [PATCH] net: Keep interface binding when sending packets with ipi_ifindex = 0 Andrew Morton
2009-07-30  0:10   ` John Dykstra
2009-08-04  4:23     ` David Miller
2009-08-04  7:36       ` Chia-chi Yeh (葉家齊)
2009-08-04  7:57         ` Badalian Vyacheslav
2009-08-04  8:28           ` Chia-chi Yeh (葉家齊) [this message]
2009-08-04 18:57         ` David Miller
2009-08-05  0:06           ` Chia-chi Yeh (葉家齊)
2009-08-05  2:33             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6c039e090908040128l7bdaf45j3305e5e392562b85@mail.gmail.com \
    --to=chiachi@android.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=john.dykstra1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=slavon@bigtelecom.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).