Re: [PATCH net-next v2] vxlan: Remove unnecessary comments for vxlan_rcv() and vxlan_err_lookup()

Nikolay Aleksandrov
2025-02-06T14:08:23Z

On 2/6/25 16:00, Ted Chen wrote:
> Remove the two unnecessary comments around vxlan_rcv() and
> vxlan_err_lookup(), which indicate that the callers are from
> net/ipv{4,6}/udp.c. These callers are trivial to find. Additionally, the
> comment for vxlan_rcv() missed that the caller could also be from
> net/ipv6/udp.c.
>
> Suggested-by: Nikolay Aleksandrov <razor@blackwall.org>
> Suggested-by: Ido Schimmel <idosch@idosch.org>
> Signed-off-by: Ted Chen <znscnchen@gmail.com>
> ---
> v2: removed the comments for vxlan_rcv() and vxlan_err_lookup().
> (Nikolay, Ido)
> v1: https://lore.kernel.org/all/20250205114448.113966-1-znscnchen@gmail.com
> ---
> drivers/net/vxlan/vxlan_core.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c
> index ece5415f9013..44eba7aa831a 100644
> --- a/drivers/net/vxlan/vxlan_core.c
> +++ b/drivers/net/vxlan/vxlan_core.c
> @@ -1670,7 +1670,6 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph,
> return err <= 1;
> }
>
> -/* Callback from net/ipv4/udp.c to receive packets */
> static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
> {
> struct vxlan_vni_node *vninode = NULL;
> @@ -1840,7 +1839,6 @@ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb)
> return 0;
> }
>
> -/* Callback from net/ipv{4,6}/udp.c to check that we have a VNI for errors */
> static int vxlan_err_lookup(struct sock *sk, struct sk_buff *skb)
> {
> struct vxlan_dev *vxlan;

LGTM,
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>