From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v3] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs Date: Wed, 14 Nov 2018 14:03:51 +0300 Message-ID: <6c22e59d-b108-0df0-548b-6590b8775f61@cogentembedded.com> References: <20181114061703.11026-1-ms@dev.tdt.de> <20181114101236.10398-1-ms@dev.tdt.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Martin Schiller , andrew@lunn.ch, f.fainelli@gmail.com Return-path: Received: from mail-lf1-f67.google.com ([209.85.167.67]:35188 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727773AbeKNVGl (ORCPT ); Wed, 14 Nov 2018 16:06:41 -0500 Received: by mail-lf1-f67.google.com with SMTP id e26so9406100lfc.2 for ; Wed, 14 Nov 2018 03:03:54 -0800 (PST) In-Reply-To: <20181114101236.10398-1-ms@dev.tdt.de> Content-Language: en-MW Sender: netdev-owner@vger.kernel.org List-ID: On 11/14/2018 01:12 PM, Martin Schiller wrote: > This commit re-enables support for slow GPIO pins. It was initially > introduced by commit 2d6c9091ab76 ("net: mdio-gpio: support access that > may sleep") and got lost by commit 7e5fbd1e0700 ("net: mdio-gpio: > Convert to use gpiod functions where possible"). > > Also add a warning about slow GPIO pins like it is done in i2c-gpio. > > Signed-off-by: Martin Schiller > --- > v3: > - modified commit summary > - fixed commit cites in commit message > - fixed line continuation > > v2: > - fixed copy/paste bug in warning about slow GPIO pins > --- > drivers/net/phy/mdio-gpio.c | 15 ++++++++++----- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c > index 33265747bf39..e1c305089172 100644 > --- a/drivers/net/phy/mdio-gpio.c > +++ b/drivers/net/phy/mdio-gpio.c [...] > @@ -162,6 +162,11 @@ static int mdio_gpio_probe(struct platform_device *pdev) > if (ret) > return ret; > > + if (gpiod_cansleep(bitbang->mdc) || gpiod_cansleep(bitbang->mdio) || > + gpiod_cansleep(bitbang->mdo)) > + dev_warn(&pdev->dev, "Slow GPIO pins might wreak havoc into" > + "MDIO bus timing"); Oops, missed this in the 1st review: you don't need to break the kernel messages like that, they may violate the 80-column limit (to facilitate searching)... [...] MBR, Sergei