From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13DF7C282C4 for ; Sat, 9 Feb 2019 20:08:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD6BB2192C for ; Sat, 9 Feb 2019 20:08:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ijRUdLZf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726898AbfBIUIW (ORCPT ); Sat, 9 Feb 2019 15:08:22 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:54551 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726836AbfBIUIW (ORCPT ); Sat, 9 Feb 2019 15:08:22 -0500 Received: by mail-wm1-f66.google.com with SMTP id a62so9763942wmh.4 for ; Sat, 09 Feb 2019 12:08:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=OSjS1xzlBdO9NbnGueBVHQan1cA75/PptQbZjMwNYU8=; b=ijRUdLZf2S72m4ZwNp8UpeWaQt3LxlOLuvICXgw9pm7KoYGGWtSAdd24orGUSR9fU2 IdQdf3e8OOmwGkbgfDp1QbOf9rWfmLUbzkR4MNaE58XAevXeS2uMXxpyWZzLf9KJrXgu hjxHDRA0YGwDyOJfd3YxR4wHcYljrsuoOIOJrQnSW9nhbhB6E84pnhgw5yAW/H/io1+Z LXCv3TGmkD53gb0vb5eXU/9Dkb+KN4WfhGzfVuLszgYaovOZipNUt/XaYy4qHbcydInV 6N8ZnNXOofex3fC+nxba5desTvbnvSgV/dCQBFbTDtGgI2iuG3urR9M/LdXbtZCnVEtJ My/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OSjS1xzlBdO9NbnGueBVHQan1cA75/PptQbZjMwNYU8=; b=SaS0lprHR/OQeKlyT0ea5Tq4gmm8UpJQK/HyU7HbmZLH/33+VhX2Qu6F+0wtyA+CKs uRzxA2pDqS6lFoNWl6K+QctZOZvgztRQG5oq1S48g57wz+NhWKNhvmJ0ojHX41NUGKhW a/Bv+biih+YnX2BENk/XL/zA4AASpu1UPmjwRDDXMJDReqL0cvfR3QRJY0Ltxq0yk8Oo dVLpvhe/IheBpXug93ucODQY9XqIpMLkWQnbd8zm9TWYF8CVRS0NjvWdrN/jr4yo/Qd+ kbXb1Xh5E6SfxccGsoI97DAv/mhujYiZ93FM7TYyQgyH2svvAxtvNzwmi2NtfxFf6S5l 5G0Q== X-Gm-Message-State: AHQUAubUMhKUq9GmZmuU+NGhFikht76XmsdXkADra6wOWPeK1Zlp42Wm S63OAbJoVoUC4a/qEbpnSFrm0bxl X-Google-Smtp-Source: AHgI3Ia/3tcLbTov3cXH9PS5a2fFuvlfJhCbDcfYxgtgLib6RrlWPbTgCzXKbIIHopAAaLfKLlNjsQ== X-Received: by 2002:a7b:c04f:: with SMTP id u15mr3647813wmc.49.1549742899463; Sat, 09 Feb 2019 12:08:19 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:51b1:297d:6b2f:4788? (p200300EA8BF1E20051B1297D6B2F4788.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:51b1:297d:6b2f:4788]) by smtp.googlemail.com with ESMTPSA id n11sm4364999wrw.60.2019.02.09.12.08.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 09 Feb 2019 12:08:18 -0800 (PST) From: Heiner Kallweit Subject: Re: [PATCH net-next] net: phy: Add support for asking the PHY its abilities To: Andrew Lunn , Maxime Chevallier Cc: Florian Fainelli , David Miller , "netdev@vger.kernel.org" References: <19c1e5c4-2f86-a3ff-e971-a0098c605b3f@gmail.com> <20190209163554.GB30856@lunn.ch> <1984f4fa-78df-bb51-5021-306ce87c3a80@gmail.com> <20190209194255.GJ30856@lunn.ch> Message-ID: <6c244d93-c656-237e-a69b-45fead43755e@gmail.com> Date: Sat, 9 Feb 2019 21:08:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 09.02.2019 20:50, Heiner Kallweit wrote: > On 09.02.2019 20:42, Andrew Lunn wrote: >>> I know, it's patch 15 in your series ;) And I'm aware that usually new >>> core functionality is acceptable only if it comes together with a user, >>> to avoid having billions of orphaned good ideas in the code. >>> I focused on the core here to not get lost in all the new stuff, and to >>> provide Maxime with some direction for adjusting his series. >> >> I'm just trying to avoid Maxime reimplementing something when we >> already have a patch: >> > Sure, I didn't mean Maxime should re-implement things we have in the pipe. > I meant it more in a way that he gets an idea in which direction we're moving. > >> https://github.com/lunn/linux/commit/07e3fa8f183f05a09d969a9378534da35238eeb9 >> >> Maxime, feel free to cherry-pick this into your series. >> > I'll submit this one too. > Just saw that this patch depends on patch 5 of Maxime's series. And it needs a small change because the generic function was renamed to genphy_c45_pma_read_abilities(). So indeed it may be better if Maxime adds this patch to his series. One comment regarding the pause bits in Maxime's patch 5: If no pause bit is set the core automatically sets both. So we have to do this neither in the marvell10g driver nor in the generic read-abilities function. >> Andrew >> Heiner > Heiner > > Oh, and I just saw: When we talk about/with somebody, we should add him to the > mail addressee list. >