From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D53AC433EF for ; Wed, 2 Mar 2022 18:11:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242031AbiCBSMA (ORCPT ); Wed, 2 Mar 2022 13:12:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236621AbiCBSL7 (ORCPT ); Wed, 2 Mar 2022 13:11:59 -0500 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D4FE675221 for ; Wed, 2 Mar 2022 10:11:15 -0800 (PST) Received: from [192.168.1.214] (dynamic-089-014-155-020.89.14.pool.telefonica.de [89.14.155.20]) by linux.microsoft.com (Postfix) with ESMTPSA id 8922020B7178; Wed, 2 Mar 2022 10:11:14 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8922020B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1646244675; bh=wnNxxKJhkbCQZA6MR48J0yJP1hDi/gPWM9pPHYM7Il0=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=RKPY8/WLcodYi6GvwmfAozvyUyE7gVN2ld7er/uPxYunMgMKN0oGFO4huvk1IY5js D/ZZbN9B4M2DxouX06NulIU2xryaSI1PH4JZq/FqvawQIetZ/4U5i50ZV76wH175TQ +CcRFCuylSMf60HqzBSSpi60jFd58om7vo8hwJuA= Subject: Re: [PATCH 1/2] Revert "xfrm: interface with if_id 0 should return error" To: Jakub Kicinski , Steffen Klassert Cc: Paul Chaignon , Eyal Birger , netdev@vger.kernel.org References: <20220301131512.1303-1-kailueke@linux.microsoft.com> <20220301150930.GA56710@Mem> <20220301161001.GV1223722@gauss3.secunet.de> <20220302080439.2324c5d0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> From: Kai Lueke Message-ID: <6c2d3e6b-23f8-d4a4-4701-ff9288c18a5c@linux.microsoft.com> Date: Wed, 2 Mar 2022 19:11:06 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20220302080439.2324c5d0@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, > Agreed. FWIW would be great if patch #2 started flowing towards Linus'es > tree separately if the discussion on #1 is taking longer. to preserve the initial goal of helping to uncover id 0 usage I think it would be best to have the revert be accompanied by a patch that instead creates a kernel log warning (or whatever). Since I never did that I suggest to not wait for me. Also, feel free to do the revert yourself with a different commit message if mine didn't capture the things appropriately. Regards, Kai