From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Wise Subject: Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information Date: Mon, 26 Mar 2018 12:13:53 -0500 Message-ID: <6c376ad8-7b42-8b13-1eba-328fecd0e3bd@opengridcomputing.com> References: <743dc7a5306f9b3368fcd4c143cdd822250444a6.1520020530.git.swise@opengridcomputing.com> <0443b8e0-17ff-1e62-51ba-ba1fa0e0d529@opengridcomputing.com> <8d788e10-c170-9b94-09f0-98515fdd5bac@gmail.com> <783e600a-9296-8ea0-003e-59e48fd5234b@opengridcomputing.com> <20180326150826.GH1877@mtr-leonro.local> <09f5080f-04d2-3b5e-74fd-7aba85516097@opengridcomputing.com> <20180326170647.GL1877@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8BIT Cc: David Ahern , stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org To: Leon Romanovsky Return-path: Received: from opengridcomputing.com ([70.118.0.34]:48545 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbeCZRNw (ORCPT ); Mon, 26 Mar 2018 13:13:52 -0400 In-Reply-To: <20180326170647.GL1877@mtr-leonro.local> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 3/26/2018 12:06 PM, Leon Romanovsky wrote: > On Mon, Mar 26, 2018 at 10:24:25AM -0500, Steve Wise wrote: >> >> On 3/26/2018 10:08 AM, Leon Romanovsky wrote: >>> On Mon, Mar 26, 2018 at 09:55:46AM -0500, Steve Wise wrote: >>>> On 3/26/2018 9:44 AM, David Ahern wrote: >>>>> On 3/26/18 8:30 AM, Steve Wise wrote: >>>>>> On 3/26/2018 9:17 AM, David Ahern wrote: >>>>>>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>>>>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>>>>>> index 5809f70..e55205b 100644 >>>>>>>> --- a/rdma/rdma.h >>>>>>>> +++ b/rdma/rdma.h >>>>>>>> @@ -18,10 +18,12 @@ >>>>>>>> #include >>>>>>>> #include >>>>>>>> #include >>>>>>>> +#include >>>>>>>> >>>>>>>> #include "list.h" >>>>>>>> #include "utils.h" >>>>>>>> #include "json_writer.h" >>>>>>>> +#include >>>>>>>> >>>>>>> did you forget to add rdma_cma.h? I don't see that file in my repo. >>>>>> It is provided by the rdma-core package, upon which rdma tool now >>>>>> depends for the rdma_port_space enum. >>>>>> >>>>> You need to add a check for the package, and only build rdma if that >>>>> package is installed. See check_mnl in configure for an example. >>>> Ok, that makes sense. >>> IMHO, better solution will be to copy those files to iproute2. >> Hey Leon, >> >> Why is it better in your opinion?  My gut tells me adding rdma_cma.h to >> iproute2 means more uabi type syncing. > Making rdmatool be dependant on rdma-core will require that distributions > will update their specs to install rdma-core as a dependency for every > iprotue2 install. > > The rdma-core dependency makes sense for RDMA users, but doesn't for most of > the iproute2 users. I'm fuzzy on the details of distro packaging, but David's suggestion is that rdmatool wouldn't get built if rdma-core isn't present. But everything else would.  Just like it does not get built if libmnl is not installed.  For pre-built rpms, the rdma-core would have to be present.  I'm ok pulling it in, I'm just trying to understand. :) Steve.